1. 04 Nov, 2016 4 commits
    • José Iván's avatar
      Cleaned up global namespace JS · b1b51b77
      José Iván authored
      Moved most of the functions that contained "window.doSomething" that were located at:
      - app/assets/javascripts/application.js
      To the following file:
      - app/assets/javascripts/lib/utils/common_utils.js
      
      The functions listed here:
      - window.ajaxGet
      - window.split
      - window.extractLast
      - window.rstrip
      - window.disableButtonIfEmptyField
      - window.disableButtonIfAnyEmptyField
      - window.sanitize
      - window.unbindEvents
      - window.shiftWindow
      
      Now will be accessible from the "gl.utils" namespace
      b1b51b77
    • Alfredo Sumaran's avatar
      Merge branch 'fix-invalid-filename-eslint' into 'master' · 3a8a7c12
      Alfredo Sumaran authored
      eslint: Fix invalid filename validation
      
      Attempt to fix the following error which is appearing in every new MR since `eslint-plugin-filenames` was introduced.
      
      ```
      /builds/gitlab-org/gitlab-ce/app/assets/javascripts/gl_field_error.js.es6
        2:1  error  Filename 'gl_field_error.js.es6' does not match the naming convention  filenames/match-regex
      ```
      
      This was happening because our ES6 files have the following structure `gl_hello_world.js.es6`. So `eslint-plugin-filenames` was considering as base name `gl_hello_world.js` which didn't pass the previous regex `^[a-z_]+$`
      
      This new regex allows the following filenames to pass as valid:
      
      - `gl_hello_world.js.es6` which base name translates to `gl_hello_world.js` 
      -  `gl_foo_bar.js` which base name translates to `gl_foo_bar`
      -  `d3.js` which base name translates to `d3` (especial case, maybe we should move this to the vendor dir and make the regex more specific)
      
      See merge request !7281
      3a8a7c12
    • Alfredo Sumaran's avatar
      Add CHANGELOG entry file · 99a000da
      Alfredo Sumaran authored
      99a000da
    • Alfredo Sumaran's avatar
      Add jquery.timeago.js to application.js · 6e1802d0
      Alfredo Sumaran authored
      6e1802d0
  2. 03 Nov, 2016 32 commits
  3. 02 Nov, 2016 4 commits