- 02 Dec, 2014 12 commits
-
-
Dmitriy Zaporozhets authored
Improve MR reloading ## Theory Every time you pushed to master it updates merge requests that has master as target branch. So if you have 50 open merge requests point to master it will reload all of them every time you push a single commit to master. The funny thing is that after reloading diff of most merge requests looks the same. After this patch we update diff only if we push commit to master that includes in MR commits list. For example we have next repository: feature: A - B - C master: A We create merge request with code from feature to master. MR: B - C If we push to master commit D - MR will not be reloaded. So picture will look next: feature: A - B - C master: A - D MR: B - C And if we push to master commit B - MR will be reloaded. So picture will look next: feature: A - B - C master: A - B MR: C ## Benchmark For project with 45 open merge requests to master Before ``` Benchmark post-receive | Cache and size: 0.060000 0.040000 0.100000 ( 0.379720) Benchmark post-receive | Push commits selection: 0.130000 0.020000 0.150000 ( 0.149299) Benchmark post-receive | Update merge requests: 9.180000 2.030000 11.210000 ( 11.971747) Benchmark post-receive | Process commit messages: 0.140000 0.010000 0.150000 ( 0.168810) Benchmark post-receive | Push data: 0.020000 0.000000 0.020000 ( 0.016363) Benchmark post-receive | Push event and services: 0.030000 0.000000 0.030000 ( 0.088062) ``` After ``` Benchmark post-receive | Cache and size: 0.070000 0.030000 0.100000 ( 0.106676) Benchmark post-receive | Push commits selection: 0.130000 0.020000 0.150000 ( 0.143081) Benchmark post-receive | Update merge requests: 0.660000 0.210000 0.870000 ( 0.892663) Benchmark post-receive | Process commit messages: 0.030000 0.000000 0.030000 ( 0.029263) Benchmark post-receive | Push data: 0.020000 0.000000 0.020000 ( 0.018479) Benchmark post-receive | Push event and services: 0.030000 0.000000 0.030000 ( 0.038230) ``` - - - ## References Discussion in gitlab/gitlabhq#1796 See merge request !1288
-
Dmitriy Zaporozhets authored
Update libv8 For some reason I could no longer install the previous version of libv8 on my development machine; this version bump fixes that. I do not know if/how this change affects production environments. See merge request !1287
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Every time you pushed to master it updates merge requests that has master as target branch. So if you have 50 open merge requests point to master it will reload all of them every time you push a single commit to master. The funny thing is that after reloading diff of most merge requests looks the same. After this patch we update diff only if we push commit to master that includes in MR commits list. For example we have next repository: feature: A - B - C master: A We create merge requests #1 with code from feature to master. MR #1: B - C If we push to master commit D - MR will not be reloaded. So picture will look next: feature: A - B - C master: A - D MR #1: B - C And if we push to master commit B - MR will be reloaded. So picture will look next: feature: A - B - C master: A - B MR #1: C Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Jacob Vosmaer authored
This selfish change fixes 'bundle install' on my (OS X) development machine.
-
Dmitriy Zaporozhets authored
Improve mobile UI pt2 Next UI elements were improved for mobile view * comments * comment form * issues navigation * removed duplicate MR sidebar btn * tabs Desktop improvements: * increase comment author username font size * dark colour for comment author name Related to #1493 See merge request !1285
-
Dmitriy Zaporozhets authored
Disable Sidekiq arguments logging by default Some of the arguments passed to Sidekiq jobs are secret. With this change we avoid logging those secrets, by turning off 'argument logging' altogether. See merge request !1282
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: CHANGELOG
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Sytse Sijbrandij authored
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 01 Dec, 2014 15 commits
-
-
Jacob Vosmaer authored
-
Sytse Sijbrandij authored
Change twitter handle from gitlabhq -> gitlab
-
Robert Schilling authored
-
Dmitriy Zaporozhets authored
Username in comments Its hard to mention person in comment if you don't know his username. This patch show person username right after his name in comment row See merge request !1281
-
Dmitriy Zaporozhets authored
HipChat custom server support
-
Marin Jankovski authored
-
Marin Jankovski authored
add preliminary 7.6 upgrade guide
-
Marin Jankovski authored
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Fix internal api Fixes #1787 See merge request !1280
-
Dmitriy Zaporozhets authored
Remove unused password argument We no longer put a (random) password in the 'new user' email, so no need to pass it around in the code. See merge request !1279
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Jacob Vosmaer authored
We were still passing a 'password' argument around, but it is not used anywhere because we send a password reset link in the welcome email nowadays.
-
Sytse Sijbrandij authored
Improve security release documentation I think the MailChimp step is not needed anymore because we automated it. See merge request !1271
-
- 30 Nov, 2014 10 commits
-
-
Dmitriy Zaporozhets authored
Properly fix wiki restore My previous patch didn't fix the restore issue (!247). ProjectWiki.new() creates a new wiki git repository, so any tries to bare clone a bundle fail. With this patch we remove the newly created wiki.git before restoring from the backup bundle. \cc @jacobvosmaer @dzaporozhets are you ok with this solution/hack? Relevant issues: #845 See merge request !248
-
Achilleas Pipinellis authored
ProjectWiki.new() creates a new wiki git repository, so any tries to bare clone a bundle fail. With this patch we remove the newly created wiki.git before restoring from the backup bundle.
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> Conflicts: CONTRIBUTING.md
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Reactivate highlight.js language autodetection ### What does this MR do? This commit partly reverts commit 0d13abb1 to reactivate highlight.js language autodetection. It does NOT revert the part that adds the `nohighlight` CSS-class for a predefined set of filenames (which was indeed the intended purpose of commit 0d13abb1). ### Are there points in the code the reviewer needs to double check? Not particularly, the only effect of this blob_helper is to add a CSS class to the `<pre>` container of the blob, to control the way highlight.js performs its syntax highlighting. (see where this helper is called at https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/shared/_file_hljs.html.haml#L12). However this merge request DOES change the way the syntax highlighting is done (by bringing it back to the situation before commit 0d13abb1 where highlight.js autodetected the language itself). So we can expect some new kind of syntax highlighting problems. However in this case, the issues should be forwarded to the upstream project (https://github.com/isagalaev/highlight.js). ### Why was this MR needed? The main motivation behind this partial revert is that there is no point (IMHO) in using an "intelligent" syntax highlighter which is specifically designed to autodetect languages if it is to dictate (via the CSS class) the language to use solely based on the filename extension. ### What are the relevant issue numbers / Feature requests? Issue #665 "HLJS language autodetection / syntax highlighting fails " ### Screenshots (If appropriate) See screenshots in issue #665 See merge request !232
-
Dmitriy Zaporozhets authored
Fixed an alignment issue, fixes #778 This merge request fixes issue #778. I have figured out the problem already here: https://gitlab.com/gitlab-org/gitlab-ce/issues/778#note_366548 See merge request !242
-
Dmitriy Zaporozhets authored
Fix wiki restore Seems 4a5044e3 only fixed git repos restore. This MR provides the same functionality that was introduced in the aforementioned commit, but for wikis. See merge request !247
-
Dmitriy Zaporozhets authored
Make clear that the upgrader script does not update gitlab-shell There are many cases where people end up with a broken update because they don't update gitlab-shell. For example: https://twitter.com/hgomez/status/537902038907363330 \cc @sytses See merge request !246
-
Dmitriy Zaporozhets authored
Create project & repository at the same time * block project creation if repository cant be created * show proper error message about failed to create repository * dont use ajax for project creation any more - its fast enough * if project repository does not exist - propose to create one or import * move import functionality to separate resource Fixes #1768 See merge request !1278
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 29 Nov, 2014 3 commits
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-