Commit 3dbabf8a authored by Julien Muchembled's avatar Julien Muchembled

Revert "Make newContent call _edit sooner (before computing local roles)"

66cb9c96 prevented init scripts to be used to
set default values, so original order of initialization must be reverted.
_edit may also trigger interactions that require workflows to be initialized.

Code simplication is kept, and _edit **kw is now passed to init script as an
alternate way for init scripts to know properties given to newContent.
parent 8c4fb3f8
master allmywork allow_login_change allow_login_change_differentiate_id_and_login allow_login_change_wip arnau arnau-kns arnau-kns-without-property-mapping arnau-merge arnau-poc auto_extend_select_list autoflake backup_erp5_workflow bk_erp5ish_actions_tool bk_sqlcatalog boc-interaction-drop cache catalog_fulltext catalog_fulltext_old cedric cedriclen cedriclen-eos certificate_authority cherries cherry-pick-4a8e045d cleanJSByJSLint clean_up_upgrader compact_title_no_reference credential_update_action datetimefield deferred_listbox devel douglas_forum dream_distributor drop-legacy-simulation eos-dev erp5-component erp5-data-notebook erp5-forum erp5-preference erp5-release erp5-slapos-upgrade erp5-util-testing erp5-vifib erp5-vifib-cleanup erp5_calendar erp5_free_subscription erp5_workflow feature/renderjs-form-error-handling feature/renderjs-formbox feature/renderjs-listbox-columnsort feature/renderjs-reports feature/rjs-listbox-stats fix/accounting_period_constraint_vs_acquired_node fix/change_state_priority fix/login_validate_check_consistency fix_system_processes_ownership for_testrunner_1 for_testrunner_2 formbox gabriel gabriel-fix-rounding-in-accounting-generation gabriel-fix-rounding-in-accounting-generation2 gadget-json-value http_cache_fix improve_default_caching_policy_manager interaction-drop isDeletable item_tracking_graph_editor ivan jerome-bt-reference-doc jerome-test jerome_events jerome_graph_editor_renderjs jerome_new_style_solve_divergence jerome_promise_in_tests jerome_user_preference_time_zone jio jm/form-action-guard joblib-activity kato kns lazy_simulation_causality lignan lingnan listbox-generator mame mame-bt5-cleanup mame-erp5_project-cleanup mame-naming-convention mame-naming-convention-list_method mame-test-stock-indexation mame-work mame2 master-erp5-test-result-scalability master-erp5-test-result-scalability-rebase master-test-fix-additionalbt5path master_calendar_wip_patches master_calendar_wip_patches_extend_security master_no_guard_on_workflow_transition master_no_guard_on_workflow_transition_plus_calendar_wip_patchs merge_xhtml_jquery mmariani-inventory mrp new-render-presentation nexedi-erp5-jp no_longer_simulated_state officejs officejs_clean pere portal_callables portal_solver_process_security_configuration presentation rebased_mrp reindex_calendar_after_change_calendar_exception renderjs/test romain-fulltext scalability-master2 scalability-master2-rebase scalability-rebase shop-box simulation sms_more_than_140_characters strict_catalog syncml test/rjs test/rjsacc test/rjsfull test/tmp test/ui test_page testnode_software_link timezones tristan tristan-merge tristan-performance ttr ttrm upgradeSite view-aggregated-amounts vivekpab_erp5webrenderjs_layoutconfig vivekpab_jabberclient vivekpab_renderjs_interfaces wenjie wenjie_branch xiaowu_newui yryr yryr-components-cp yryr-inventory-cache yryr-test yryr-with-components yusei test-ui test-rjsfull test-rjsacc test-rjs renderjs-test nexedi/master jio-reports-old feature-jio-reports erp5.util-0.4.49 erp5.util-0.4.46 erp5.util-0.4.44 erp5.util-0.4.43 erp5.util-0.4.41 erp5.util-0.4.40 erp5.util-0.4.37 erp5.util-0.4.1 erp5.util-0.4 erp5.util-0.3 erp5.util-0.2 erp5.util-0.1
No related merge requests found
...@@ -400,9 +400,6 @@ class ERP5TypeInformation(XMLObject, ...@@ -400,9 +400,6 @@ class ERP5TypeInformation(XMLObject,
# in order to initialize aq_dynamic # in order to initialize aq_dynamic
ob.portal_type = self.getId() ob.portal_type = self.getId()
if kw:
ob._edit(force_update=1, **kw)
if compute_local_role: if compute_local_role:
# Do not reindex object because it's already done by manage_afterAdd # Do not reindex object because it's already done by manage_afterAdd
self.updateLocalRolesOnDocument(ob, reindex=False) self.updateLocalRolesOnDocument(ob, reindex=False)
...@@ -419,7 +416,11 @@ class ERP5TypeInformation(XMLObject, ...@@ -419,7 +416,11 @@ class ERP5TypeInformation(XMLObject,
init_script = self.getTypeInitScriptId() init_script = self.getTypeInitScriptId()
if init_script: if init_script:
# Acquire the init script in the context of this object # Acquire the init script in the context of this object
getattr(ob, init_script)(created_by_builder=created_by_builder) getattr(ob, init_script)(created_by_builder=created_by_builder,
edit_kw=kw)
if kw:
ob._edit(force_update=1, **kw)
return ob return ob
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment