commit_spec.rb 15.1 KB
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421
# == Schema Information
#
# Table name: commits
#
#  id           :integer          not null, primary key
#  project_id   :integer
#  ref          :string(255)
#  sha          :string(255)
#  before_sha   :string(255)
#  push_data    :text
#  created_at   :datetime
#  updated_at   :datetime
#  tag          :boolean          default(FALSE)
#  yaml_errors  :text
#  committed_at :datetime
#

require 'spec_helper'

describe Ci::Commit do
  let(:project) { FactoryGirl.create :ci_project }
  let(:gl_project) { FactoryGirl.create :empty_project, gitlab_ci_project: project }
  let(:commit) { FactoryGirl.create :ci_commit, gl_project: gl_project }

  it { is_expected.to belong_to(:gl_project) }
  it { is_expected.to have_many(:statuses) }
  it { is_expected.to have_many(:trigger_requests) }
  it { is_expected.to have_many(:builds) }
  it { is_expected.to validate_presence_of :sha }

  it { is_expected.to respond_to :git_author_name }
  it { is_expected.to respond_to :git_author_email }
  it { is_expected.to respond_to :short_sha }

  describe :ordered do
    let(:project) { FactoryGirl.create :empty_project }

    it 'returns ordered list of commits' do
      commit1 = FactoryGirl.create :ci_commit, committed_at: 1.hour.ago, gl_project: project
      commit2 = FactoryGirl.create :ci_commit, committed_at: 2.hour.ago, gl_project: project
      expect(project.ci_commits.ordered).to eq([commit2, commit1])
    end

    it 'returns commits ordered by committed_at and id, with nulls last' do
      commit1 = FactoryGirl.create :ci_commit, committed_at: 1.hour.ago, gl_project: project
      commit2 = FactoryGirl.create :ci_commit, committed_at: nil, gl_project: project
      commit3 = FactoryGirl.create :ci_commit, committed_at: 2.hour.ago, gl_project: project
      commit4 = FactoryGirl.create :ci_commit, committed_at: nil, gl_project: project
      expect(project.ci_commits.ordered).to eq([commit2, commit4, commit3, commit1])
    end
  end

  describe :last_build do
    subject { commit.last_build }
    before do
      @first = FactoryGirl.create :ci_build, commit: commit, created_at: Date.yesterday
      @second = FactoryGirl.create :ci_build, commit: commit
    end

    it { is_expected.to be_a(Ci::Build) }
    it('returns with the most recently created build') { is_expected.to eq(@second) }
  end

  describe :retry do
    before do
      @first = FactoryGirl.create :ci_build, commit: commit, created_at: Date.yesterday
      @second = FactoryGirl.create :ci_build, commit: commit
    end

    it "creates only a new build" do
      expect(commit.builds.count(:all)).to eq 2
      expect(commit.statuses.count(:all)).to eq 2
      commit.retry
      expect(commit.builds.count(:all)).to eq 3
      expect(commit.statuses.count(:all)).to eq 3
    end
  end

  describe :valid_commit_sha do
    context 'commit.sha can not start with 00000000' do
      before do
        commit.sha = '0' * 40
        commit.valid_commit_sha
      end

      it('commit errors should not be empty') { expect(commit.errors).not_to be_empty }
    end
  end

  describe :short_sha do
    subject { commit.short_sha }

    it 'has 8 items' do
      expect(subject.size).to eq(8)
    end
    it { expect(commit.sha).to start_with(subject) }
  end

  describe :stage do
    subject { commit.stage }

    before do
      @second = FactoryGirl.create :commit_status, commit: commit, name: 'deploy', stage: 'deploy', stage_idx: 1, status: 'pending'
      @first = FactoryGirl.create :commit_status, commit: commit, name: 'test', stage: 'test', stage_idx: 0, status: 'pending'
    end

    it 'returns first running stage' do
      is_expected.to eq('test')
    end

    context 'first build succeeded' do
      before do
        @first.success
      end

      it 'returns last running stage' do
        is_expected.to eq('deploy')
      end
    end

    context 'all builds succeeded' do
      before do
        @first.success
        @second.success
      end

      it 'returns nil' do
        is_expected.to be_nil
      end
    end
  end

  describe :create_next_builds do
  end

  describe :refs do
    subject { commit.refs }

    before do
      FactoryGirl.create :commit_status, commit: commit, name: 'deploy'
      FactoryGirl.create :commit_status, commit: commit, name: 'deploy', ref: 'develop'
      FactoryGirl.create :commit_status, commit: commit, name: 'deploy', ref: 'master'
    end

    it 'returns all refs' do
      is_expected.to contain_exactly('master', 'develop', nil)
    end
  end

  describe :retried do
    subject { commit.retried }

    before do
      @commit1 = FactoryGirl.create :ci_build, commit: commit, name: 'deploy'
      @commit2 = FactoryGirl.create :ci_build, commit: commit, name: 'deploy'
    end

    it 'returns old builds' do
      is_expected.to contain_exactly(@commit1)
    end
  end

  describe :create_builds do
    let!(:commit) { FactoryGirl.create :ci_commit, gl_project: gl_project }

    def create_builds(trigger_request = nil)
      commit.create_builds('master', false, nil, trigger_request)
    end

    def create_next_builds
      commit.create_next_builds(commit.builds.order(:id).last)
    end

    it 'creates builds' do
      expect(create_builds).to be_truthy
      commit.builds.update_all(status: "success")
      expect(commit.builds.count(:all)).to eq(2)

      expect(create_next_builds).to be_truthy
      commit.builds.update_all(status: "success")
      expect(commit.builds.count(:all)).to eq(4)

      expect(create_next_builds).to be_truthy
      commit.builds.update_all(status: "success")
      expect(commit.builds.count(:all)).to eq(5)

      expect(create_next_builds).to be_falsey
    end

    context 'for different ref' do
      def create_develop_builds
        commit.create_builds('develop', false, nil, nil)
      end

      it 'creates builds' do
        expect(create_builds).to be_truthy
        commit.builds.update_all(status: "success")
        expect(commit.builds.count(:all)).to eq(2)

        expect(create_develop_builds).to be_truthy
        commit.builds.update_all(status: "success")
        expect(commit.builds.count(:all)).to eq(4)
        expect(commit.refs.size).to eq(2)
        expect(commit.builds.pluck(:name).uniq.size).to eq(2)
      end
    end

    context 'for build triggers' do
      let(:trigger) { FactoryGirl.create :ci_trigger, project: project }
      let(:trigger_request) { FactoryGirl.create :ci_trigger_request, commit: commit, trigger: trigger }

      it 'creates builds' do
        expect(create_builds(trigger_request)).to be_truthy
        expect(commit.builds.count(:all)).to eq(2)
      end

      it 'rebuilds commit' do
        expect(create_builds).to be_truthy
        expect(commit.builds.count(:all)).to eq(2)

        expect(create_builds(trigger_request)).to be_truthy
        expect(commit.builds.count(:all)).to eq(4)
      end

      it 'creates next builds' do
        expect(create_builds(trigger_request)).to be_truthy
        expect(commit.builds.count(:all)).to eq(2)
        commit.builds.update_all(status: "success")

        expect(create_next_builds).to be_truthy
        expect(commit.builds.count(:all)).to eq(4)
      end

      context 'for [ci skip]' do
        before do
          allow(commit).to receive(:git_commit_message) { 'message [ci skip]' }
        end

        it 'rebuilds commit' do
          expect(commit.status).to eq('skipped')
          expect(create_builds).to be_truthy

          # since everything in Ci::Commit is cached we need to fetch a new object
          new_commit = Ci::Commit.find_by_id(commit.id)
          expect(new_commit.status).to eq('pending')
        end
      end
    end

    context 'properly creates builds when "when" is defined' do
      let(:yaml) do
        {
          stages: ["build", "test", "test_failure", "deploy", "cleanup"],
          build: {
            stage: "build",
            script: "BUILD",
          },
          test: {
            stage: "test",
            script: "TEST",
          },
          test_failure: {
            stage: "test_failure",
            script: "ON test failure",
            when: "on_failure",
          },
          deploy: {
            stage: "deploy",
            script: "PUBLISH",
          },
          cleanup: {
            stage: "cleanup",
            script: "TIDY UP",
            when: "always",
          }
        }
      end

      before do
        stub_ci_commit_yaml_file(YAML.dump(yaml))
      end

      it 'properly creates builds' do
        expect(create_builds).to be_truthy
        expect(commit.builds.pluck(:name)).to contain_exactly('build')
        expect(commit.builds.pluck(:status)).to contain_exactly('pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'success', 'pending')
        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'deploy')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'deploy', 'cleanup')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'success', 'success', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'success', 'success', 'success')
        expect(commit.status).to eq('success')
      end

      it 'properly creates builds when test fails' do
        expect(create_builds).to be_truthy
        expect(commit.builds.pluck(:name)).to contain_exactly('build')
        expect(commit.builds.pluck(:status)).to contain_exactly('pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'pending')
        commit.builds.running_or_pending.each(&:drop)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'test_failure')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'failed', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'test_failure', 'cleanup')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'failed', 'success', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'failed', 'success', 'success')
        expect(commit.status).to eq('failed')
      end

      it 'properly creates builds when test and test_failure fails' do
        expect(create_builds).to be_truthy
        expect(commit.builds.pluck(:name)).to contain_exactly('build')
        expect(commit.builds.pluck(:status)).to contain_exactly('pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'pending')
        commit.builds.running_or_pending.each(&:drop)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'test_failure')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'failed', 'pending')
        commit.builds.running_or_pending.each(&:drop)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'test_failure', 'cleanup')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'failed', 'failed', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'test_failure', 'cleanup')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'failed', 'failed', 'success')
        expect(commit.status).to eq('failed')
      end

      it 'properly creates builds when deploy fails' do
        expect(create_builds).to be_truthy
        expect(commit.builds.pluck(:name)).to contain_exactly('build')
        expect(commit.builds.pluck(:status)).to contain_exactly('pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'deploy')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'success', 'pending')
        commit.builds.running_or_pending.each(&:drop)

        expect(commit.builds.pluck(:name)).to contain_exactly('build', 'test', 'deploy', 'cleanup')
        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'success', 'failed', 'pending')
        commit.builds.running_or_pending.each(&:success)

        expect(commit.builds.pluck(:status)).to contain_exactly('success', 'success', 'failed', 'success')
        expect(commit.status).to eq('failed')
      end
    end
  end

  describe "#finished_at" do
    let(:commit) { FactoryGirl.create :ci_commit }

    it "returns finished_at of latest build" do
      build = FactoryGirl.create :ci_build, commit: commit, finished_at: Time.now - 60
      FactoryGirl.create :ci_build, commit: commit, finished_at: Time.now - 120

      expect(commit.finished_at.to_i).to eq(build.finished_at.to_i)
    end

    it "returns nil if there is no finished build" do
      FactoryGirl.create :ci_not_started_build, commit: commit

      expect(commit.finished_at).to be_nil
    end
  end

  describe "coverage" do
    let(:project) { FactoryGirl.create :ci_project, coverage_regex: "/.*/" }
    let(:gl_project) { FactoryGirl.create :empty_project, gitlab_ci_project: project }
    let(:commit) { FactoryGirl.create :ci_commit, gl_project: gl_project }

    it "calculates average when there are two builds with coverage" do
      FactoryGirl.create :ci_build, name: "rspec", coverage: 30, commit: commit
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, commit: commit
      expect(commit.coverage).to eq("35.00")
    end

    it "calculates average when there are two builds with coverage and one with nil" do
      FactoryGirl.create :ci_build, name: "rspec", coverage: 30, commit: commit
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, commit: commit
      FactoryGirl.create :ci_build, commit: commit
      expect(commit.coverage).to eq("35.00")
    end

    it "calculates average when there are two builds with coverage and one is retried" do
      FactoryGirl.create :ci_build, name: "rspec", coverage: 30, commit: commit
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 30, commit: commit
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, commit: commit
      expect(commit.coverage).to eq("35.00")
    end

    it "calculates average when there is one build without coverage" do
      FactoryGirl.create :ci_build, commit: commit
      expect(commit.coverage).to be_nil
    end
  end
end