1. 25 Mar, 2016 1 commit
    • Kirill Smelkov's avatar
      There is no need to keep old hooks around - remove them · bbe699e2
      Kirill Smelkov authored
      gitlab-shell uses completely own whole set of git hooks and just
      symlinks repo.git/hooks to path/to/gitlab-shell/hooks/.
      
      Original hooks that git added there - when initializing repository -
      from its template, and which are by default deactivated, are currently
      moved to repos.git/hooks.old.<timestamp>, e.g.
      
      $ ls -F nexedi/helloweb.git/
          config
          description
          HEAD
          hooks@                  -->  ...path/to/gitlab-shell/hooks/
          hooks.old.1446564288/
          info/
          packed-refs
          refs/
      
      $ ls -F nexedi/helloweb.git/hooks.old.1446564288/
          applypatch-msg.sample*
          post-update.sample*
          pre-commit.sample*
          pre-push.sample*
          update.sample*
          commit-msg.sample*
          pre-applypatch.sample*
          prepare-commit-msg.sample*
          pre-rebase.sample*
      
      On the other hand, hooks.old.<timestamp> are not used anywhere and are
      left there "just in case". But what is the point to keep those pristine
      samples git creates by default? And we are sure those files are always
      results of gitlab-shell initializing a repository, as it is
      gitlab-shell's job to create/remove/update/etc repositories.
      
      So do not keep old hooks, remove them.
      
      P.S. The patch that introduced whole-hooks-dir-symlinking is
          db81327b (Symlink the whole hooks directory).
      
      /cc @dzaporozhets, @jacobvosmaer
      bbe699e2
  2. 08 Mar, 2016 1 commit
  3. 03 Mar, 2016 3 commits
  4. 10 Feb, 2016 5 commits
  5. 09 Feb, 2016 7 commits
  6. 05 Jan, 2016 1 commit
  7. 04 Jan, 2016 2 commits
  8. 14 Dec, 2015 2 commits
  9. 11 Dec, 2015 2 commits
  10. 01 Dec, 2015 1 commit
  11. 26 Nov, 2015 1 commit
  12. 25 Nov, 2015 8 commits
  13. 24 Nov, 2015 1 commit
    • Kirill Smelkov's avatar
      Pass $HOME to git as well · 9e087f64
      Kirill Smelkov authored
      [ this patch has the same rationale and reasoning as
        https://gitlab.com/gitlab-org/gitlab-workhorse/commit/0d0bd209
      
        details follow ]
      
      Git has 3 places for configs:
      
          - system
          - global (per user), and
          - local  (per repository)
      
      System config location is hardcoded at git compile time (to usually
      $prefix/etc/gitconfig). Local configuration is usually picked because we
      pass full repo path to subcommand. But global configuration is currently not
      picked at all, because HOME env variable is not passed to git.
      
      Pass $HOME through and let git see it's "global" config.
      
      Currently GitLab omnibus stores gitlab user name/email  + "autocrlf =
      true" in global config, so missing it should not be a blocker for
      receive/send-pack operations. But having it is more correct and can be
      handy in the future if/when more git operations are done from-under
      gitlab-shell.
      
      Having $HOME properly set is also needed when one cannot change system
      git config and have to put site-wide configuration into global git
      config under $HOME.
      
      That was the case I've hit and the reason for this patch.
      9e087f64
  14. 19 Nov, 2015 1 commit
  15. 18 Nov, 2015 1 commit
  16. 17 Nov, 2015 2 commits
  17. 12 Nov, 2015 1 commit