Merge pull request #184 from zopefoundation/davisagli-pack-error-oid

Report full oid of missing object during pack

Merge pull request #184 from zopefoundation/davisagli-pack-error-oid
Report full oid of missing object during pack
8a1646c3 · Julien Muchembled · GitHub · 87b26549 · 9ddfb58d · 8a1646c3
Commit 8a1646c3 authored Nov 13, 2017 by Julien Muchembled Committed by GitHub Nov 13, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

CHANGES.rst CHANGES.rst +2 -1

src/ZODB/FileStorage/fspack.py src/ZODB/FileStorage/fspack.py +1 -1

No files found.
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,8 @@
 5.3.1 (unreleased)
 ==================
- Nothing changed yet.
+- If an object is missing from the index while packing a ``FileStorage``,
+  report its full ``oid``.
 5.3.0 (2017-08-30)

--- a/src/ZODB/FileStorage/fspack.py
+++ b/src/ZODB/FileStorage/fspack.py
@@ -270,7 +270,7 @@ class GC(FileStorageFormatter):
                if oid == z64 and len(oid2curpos) == 0:
                    # special case, pack to before creation time
                    continue
-                raise
+                raise KeyError(oid)
            reachable[oid] = pos
            for oid in self.findrefs(pos):