Commit d3b088a7 authored by Chris McDonough's avatar Chris McDonough

Add a comment about copying and deleting files instead of renaming.

parent a3dab253
......@@ -58,6 +58,10 @@ class BlobStorage(ProxyBase):
try:
os.rename(blobfilename, targetname)
except OSError:
# XXX CM: I don't think this is a good idea; maybe just fail
# here instead of doing a brute force copy? This is awfully
# expensive and people won't know it's happening without
# at least a warning.
target = file(targetname, "wb")
source = file(blobfilename, "rb")
utils.cp(blobfile, target)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment