- 21 Dec, 2004 4 commits
-
-
Tim Peters authored
- Object.fromFile(): renamed `header_only` arg to `skip_data`. Skipping the data is what it does, while there are at least 3 distinct notions of what "a header" means in this module. Object has two notions of "header" all by itself (& I'm still not sure why Object.serialize_header() considers the version string to be part of "the header"). - FileCache.__init__(): log a warning if reuse=True but the given file path doesn't exist. The code ignores `reuse` then (before, and now). Not sure that's the best thing to do.
-
Tim Peters authored
- Moved the logger object to module scope. There's virtually no logging of any kind done here, and I suspect that's partly because the logging object was clumsy to get at. - Figured out what the code actually does when the cache size asked for doesn't match the actual size of a pre-existing cache file. It apparently wanted to ignore the requested size then. It probably shouldn't, but leaving that for later. Still, it left its own idea of the file size out of synch with the actual file size, and that was a bug. For now, logged a warning when this happens, and changed the code to respect the actual file size.
-
Tim Peters authored
ClientCache: Removed the .tid attribute. It was never updated; the contained FileCache instance actually keeps track of the last tid. This had the happy side effect of fixing bugs in testSerialization: it was accessing .tid directly, and so was _always_ comparing None to None. Changing the test to use .getLastTid() instead means it's now testing what it always intended to test. FileCache: Removed some unused private attributes for tracking internal statistics.
-
Tim Peters authored
FileCache: removed the currentsize attribute. It was initialized to 0 but never updated. Some tests referenced it, but since it was always 0 those tests weren't getting any good from it. Don't recall (or never knew) what its intended purpose may have been. FileCache.remove(): Repaired major bug. This mistakenly stored the "this disk block is free now" status byte into the start of the serialized Object record's end_tid field (incorrect seek offset). The in-memory structures were correct then, but got out of synch with the disk file; the latter then still claimed to have info for a "live" object revision, but that revision was actually dead, and the info on disk had a corrupt end_tid value.
-
- 20 Dec, 2004 1 commit
-
-
Tim Peters authored
-
- 16 Nov, 2004 1 commit
-
-
Tim Peters authored
Collector 1581: fspack can blow up when .fs is corrupted Repaired three places where fspack referenced an undefined global while *trying* to raise CorruptedError. Added new checkCorruptionInPack() test to verify the correct exception gets raised.
-
- 11 Nov, 2004 5 commits
-
-
Tim Peters authored
type_and_adr(): Display the oid too.
-
Tim Peters authored
When the ConflictError constructor is passed a pickle, extract the module and class names without loading the pickle. A ZEO server doesn't necessarily have the implementation code for application classes, and when that's so the attempt to raise ConflictError was itself dying with an ImportError.
-
Tim Peters authored
-
Tim Peters authored
-
Tim Peters authored
Try to make more sense of the ZODB pickle format "docs".
-
- 06 Nov, 2004 1 commit
-
-
Tim Peters authored
-
- 05 Nov, 2004 1 commit
-
-
Tim Peters authored
-
- 26 Oct, 2004 1 commit
-
-
Tim Peters authored
Document _p_invalidate().
-
- 18 Oct, 2004 1 commit
-
-
Dmitry Vasiliev authored
-
- 15 Oct, 2004 2 commits
-
-
Dmitry Vasiliev authored
-
Dmitry Vasiliev authored
Now use ZODB.utils.z64 instead of '\0\0\0\0\0\0\0\0' where appropriate.
-
- 14 Oct, 2004 2 commits
-
-
Tim Peters authored
Connection.root(): Repair error in docstring.
-
Tim Peters authored
Remove duplicate declaration and definition of py___getstate__.
-
- 08 Oct, 2004 2 commits
-
-
Tim Peters authored
Duplicate import removed.
-
Tim Peters authored
See Collector #1350. ghostify() and unghostify() detect one form of thread insanity now. In a debug build, they abort the process if it happens. In a release build, unghostify() raises SystemError, and ghostify() ignores it (ghostify() can't raise an exception).
-
- 05 Oct, 2004 1 commit
-
-
Tim Peters authored
before I went on vacation a couple weeks ago.
-
- 04 Oct, 2004 1 commit
-
-
Tim Peters authored
This rehabilitates the good part of Andreas's change; adds news; adds comments; and adds more comments about the sequence of undocumented cPickle gimmicks this relies on.
-
- 30 Sep, 2004 2 commits
-
-
Tim Peters authored
Collector #1517: History tab for ZPT does not work FileStorage.history() was reading the user, description, and extension fields out of the object pickle, due to starting the read at a wrong location.
-
Tim Peters authored
Restore the Connection._opened attribute, actually used by DB.connectionDebugInfo().
-
- 29 Sep, 2004 2 commits
-
-
Tim Peters authored
Typo repair.
-
Tim Peters authored
os.listdir() now prints errors on stdout
-
- 27 Sep, 2004 1 commit
-
-
Tim Peters authored
When raising DeprecationWarning, point the warning machinery at the caller, not at Transaction.begin() itself. As is (voice of experience <wink>), these warnings are darned near useless to track down code that needs to be changed on Zope trunk. With the change, the warnings point directly at the deprecated uses.
-
- 23 Sep, 2004 1 commit
-
-
Fred Drake authored
-
- 17 Sep, 2004 4 commits
-
-
Tim Peters authored
Rev 26842 changed cache-size parameters to type byte-size. That's a good change, but it was checked in from a wrong place (from the Zope trunk's copy of ZODB). Since we want Zope 2.8 to be usable with ZODB 3.3 too, I need to slam this change into 3.3 now. Alas, I don't understand how ZODB+ZEO got stitched into the Zope trunk (I do understand how it got stitched into the Zope3 trunk, and into the X3 branch), and it looks like that was left in a poor state.
-
Tim Peters authored
-
Tim Peters authored
So that if Zope X3-3.0 final is released while I'm on vacation, it will have the right ZODB stuff in it (although I still need to stitch this in to the Zope 3 and X3 trees).
-
Tim Peters authored
This confirms that 3.3 didn't have the 3.2.4c1 bug wherein an explict transaction abort() failed to clear Connections' memory of ReadConflictErrors.
-
- 14 Sep, 2004 4 commits
-
-
Tim Peters authored
be. Besides "the usual" release fiddling, repaired many out-of-date pieces of the ZODB programming guide; I'm sure many remain, though.
-
Tim Peters authored
transaction when a commit() fails. One test here provoked a failing commit(), which caused a later test to fail. Repaired by simply abort()'ing the failed transaction.
-
Tim Peters authored
-
Tim Peters authored
After a commit fails (raises an exception), all subsequent attempts to commit, join, or register with the transaction now raise the new TransactionFailedError. The failed transaction must be explicitly discarded now, via abort() on the transaction or begin() on its transaction manager.
-
- 10 Sep, 2004 2 commits
-
-
Tim Peters authored
-
Tim Peters authored
more was incomprehensible. Tried to repair that. Plus random improvements to ReST markup.
-
- 09 Sep, 2004 1 commit
-
-
Tim Peters authored
The ConflictError.get_{old,new}_serial() methods each did what the other was supposed to do.
-