Commit 77a3a5a5 authored by Alec Mitchell's avatar Alec Mitchell

Be a little more tolerant of encoded headers when no charset is passed or inferrable.

parent 57785248
...@@ -434,7 +434,9 @@ def _mungeHeaders(messageText, mto=None, mfrom=None, subject=None, ...@@ -434,7 +434,9 @@ def _mungeHeaders(messageText, mto=None, mfrom=None, subject=None,
if subject: if subject:
# remove any existing header otherwise we get two # remove any existing header otherwise we get two
del mo['Subject'] del mo['Subject']
mo['Subject'] = Header(subject, charset) # Perhaps we should ignore errors here and pass 8bit strings
# on encoding errors
mo['Subject'] = Header(subject, charset, errors='replace')
elif not mo.get('Subject'): elif not mo.get('Subject'):
mo['Subject'] = '[No Subject]' mo['Subject'] = '[No Subject]'
...@@ -491,9 +493,9 @@ def _encode_address_string(text, charset): ...@@ -491,9 +493,9 @@ def _encode_address_string(text, charset):
try: try:
name.decode('us-ascii') name.decode('us-ascii')
except UnicodeDecodeError: except UnicodeDecodeError:
# Encoded strings need an extra space if charset:
# XXX: should we be this tolerant of encoding errors here? charset = Charset(charset)
charset = Charset(charset) name = charset.header_encode(name)
name = charset.header_encode(name) # We again replace rather than raise an error or pass an 8bit string
header.append(formataddr((name, addr))) header.append(formataddr((name, addr)), errors='replace')
return header return header
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment