1. 05 Apr, 2001 10 commits
    • Jim Fulton's avatar
      Moved Python 1.x compatable asyncx to their own package that takes · baa68c50
      Jim Fulton authored
      care of installing them when necessary (not for Python 2.0)
      
      Now import asyncore and asynchat as top-level modules, rather than
      from the medusa package. This makes it easier to use our custum
      version for Python 1.5 and to use the standard versions for Python
      2.x.
      
      Note that the Python 2.1b1 and 2.1b2 releases had a broken asynchat
      that causes these changes to break Zope. The Python cvs and earler and
      later versions are OK.
      baa68c50
    • Jim Fulton's avatar
      Moved Python 1.x compatable asyncx to their own package that takes · 2e1a795d
      Jim Fulton authored
      care of installing them when necessary (not for Python 2.0)
      2e1a795d
    • Barry Warsaw's avatar
      Changes to make the tests more robust under Windows. · 48083622
      Barry Warsaw authored
      checkCreateNoFile(), checkCreateWithFilename(),
      checkCreateWithFileobj(): Make sure these tests close the file object
      before they attempt to unlink the underlying file.y
      
      checkCloseNoUnlink(), checkDel(): New tests in the CreateCommitLogTest
      class.
      
      CloseCommitLogTest: removed this class; its tests are folded into
      CreateCommitLogTest.
      48083622
    • Barry Warsaw's avatar
      _close(): Override from base class so that the storage alone is closed · 2dc88797
      Barry Warsaw authored
      (there's no DB object since we're poking at things at a lower level).
      2dc88797
    • Barry Warsaw's avatar
      Changes to make the tests more robust under Windows. · db6d6783
      Barry Warsaw authored
      tearDown(): Make sure any outstanding transactions are aborted so as
      not to retain modified objects connected to closed databases.  Second,
      call self._close() to free any resources.
      
      _close(): Close the DB object, which in turn closes the underlying
      storage.
      db6d6783
    • Chris McDonough's avatar
      aaeb1489
    • Chris McDonough's avatar
      2ee28e32
    • Chris McDonough's avatar
      Merge for collector 2137 (typo) · 1eeccb32
      Chris McDonough authored
      1eeccb32
    • Barry Warsaw's avatar
      InternalInconsistencyError => POSException.StorageSystemError · bc1f63a1
      Barry Warsaw authored
      _finish(): In delete-a-version clause, use next_dup() instead of
      next() to iterate over the currentVersions table with cursor set to
      the vid of the version we're deleting.
      
      abortVersion(): When cruising over the currentVersions table (and the
      key set to vid of the version we're aborting), use next_dup() instead
      of next().  Also, when curvid <> vid, raise StorageSystemError instead
      of VersionError.  Same later on when we check curvid <> zero.
      
      commitVersion(): Add sanity checking based on model documentation: if
      the source version is the empty string, or src == dest, raise a
      VersionCommitError.  Make the same changes we made previously to
      abortVersion() to keep track of the oids in a set/dictionary instead
      of a list to avoid duplicates.  Other fixes include, writing revid
      instead of tid==self._serial to write_moved_object() and adding a
      write_discard_version(svid) once the source version's been committed.
      
      commitVersion() now works!
      
      load(): Add another check to avoid finding an object revision in a
      committed or aborted version if we can guess that version name.  It
      now raises a VersionError if vid==zero and version is true.
      
      Also, although we still raise VersionError later on, elaborate the
      actual exception better in the error message.
      bc1f63a1
    • Barry Warsaw's avatar
      More new tests: · 5abae7de
      Barry Warsaw authored
          checkAbortVersionErrors
          checkModifyAfterAbortVersion
          checkCommitToNonVersion
          checkCommitToOtherVersion
          checkAbortOneVersionCommitTheOther
      
      All are inhibited for Minimal storage.
      5abae7de
  2. 04 Apr, 2001 10 commits
    • Barry Warsaw's avatar
      _finish(): Fixed bug that was breaking abortVersion(). The lrevid · 7b6cdb78
      Barry Warsaw authored
      (a.k.a. pickle pointer) is usually tid but not always!  In fact, it's
      specifically not tid when we've aborted a version -- it'll be the
      pointer to the pickle of the last non-version revision.  We were
      actually setting up lrevid correctly, but writing tid to the metadata
      record.  This fix writes lrevid instead.
      7b6cdb78
    • Barry Warsaw's avatar
      Fix bugs exposed by unit testing. Note that this version of the · a64b1c71
      Barry Warsaw authored
      storage has a failing abortVersion(), so it's mostly a checkpoint.
      
      Not yet tested: commitVersion(), transactionalUndo(), undoLog().
      
      Not yet implemented: history(), pack()
      
      Specific changes:
      
          - Table txnOids renamed to txnoids everywhere.
      
          - Define a module global `zero' constant and use (via global)
            where ever appropriate (should be named ZERO but that's ugly).
      
          - _finish(): Only boost the refcount of objects referenced by the
            pickle when we've actually got a new pickle.  Also, add a note
            about the currentVersions table, which will contain multiple
            copies of vid/oid records.  It's easier to weed them out later
            than to weed them out here.  One of the places you need to weed
            them all out is at the end of this method, in the
            `delete-a-version' branch.
      
          - abortVersion(): Record oids found by scanning the
            currentVersions table in a set, to account for the possible
            multiple vid/oid records.  Fix some typos.  When calling
            write_nonversion_object() on the CommitLog, the prevrevid ought
            to be the revid of the current object revision, for undo
            purposes.
      
          - load(): Where we previously had a comment that asked whether we
            should assert that the version is empty (after we've checked
            everything else), now we really check that and raise a
            VersionError if not.
      
          - loadSerial(): Fix a typo.
      
          - store(): Inside the old-revision-id-is-true test, if the old vid
            is not zero and it is equal to the new vid, then the non-version
            revision of the object is the old non-version revision (added
            the else: clause).
      
          - transactionalUndo(): Implemented but not yet tested.
      
          - undo(): Removed.
      
          - versionEmpty(): Semantics are to return true if an unknown
            version is given.  As an extra bonus, if version is empty
            (i.e. the non-version) check the serials table.
      a64b1c71
    • Barry Warsaw's avatar
      Factor out _dostore() which stores object revisions, since this is a · 0dd3eab8
      Barry Warsaw authored
      common operation. ;)  Also, _dostore() automatically pickles the data
      argument, since you don't really want anything else.
      
      Lots of new tests:
          checkNonVersionModifiedInVersion()
          checkLoadSerial()
          checkVersionedStoreAndLoad()
          checkVersionedLoadErrors()
          checkConflicts()
          checkVersionLock()
          checkVersionEmpty()
          checkVersions()
          checkAbortVersion()
      
      Skip for the Minimal storage:
          checkVersionedLoadErrors()
          checkVersionLock()
          checkVersionEmpty()
          checkVersions()
          checkAbortVersion()
      
      Override for the Minimal storage (basically check for Unsupported exceptions):
          checkLoadSerial()
          checkVersionedStoreAndLoad()
      0dd3eab8
    • Barry Warsaw's avatar
      7bf50f70
    • Barry Warsaw's avatar
      store(): convert the oserial used in the ConflictError message to a · 82175353
      Barry Warsaw authored
      long to make it more readable.
      82175353
    • Barry Warsaw's avatar
      Fix a comment · 367176d3
      Barry Warsaw authored
      367176d3
    • 's avatar
      643702cb
    • 's avatar
      88b382e1
    • Jim Fulton's avatar
      This one was redundant. · 4ad03aa6
      Jim Fulton authored
      4ad03aa6
    • 's avatar
      Fixed an assumption of 'L' trailing str() of a long · 1392c45f
      authored
      1392c45f
  3. 03 Apr, 2001 14 commits
  4. 02 Apr, 2001 6 commits