PyPy: do not call __Pyx_Coroutine_del (tp_finalize) since it resurrects dead objects (GH-4477)

5b67faba · Matti Picus · GitHub · 59e6c294 · 5b67faba · 5b67faba
Commit 5b67faba authored Nov 25, 2021 by Matti Picus Committed by GitHub Nov 25, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

Cython/Utility/Coroutine.c Cython/Utility/Coroutine.c +1 -1

tests/pypy_bugs.txt tests/pypy_bugs.txt +1 -0

tests/pypy_crash_bugs.txt tests/pypy_crash_bugs.txt +0 -4

No files found.
--- a/Cython/Utility/Coroutine.c
+++ b/Cython/Utility/Coroutine.c
@@ -1952,7 +1952,7 @@ static PyTypeObject __pyx_IterableCoroutineType_type = {
    __Pyx_Coroutine_del,                /*tp_del*/
 #endif
    0,                                  /*tp_version_tag*/
-#if PY_VERSION_HEX >= 0x030400a1
+#if PY_VERSION_HEX >= 0x030400a1 && !CYTHON_COMPILING_IN_PYPY
    __Pyx_Coroutine_del,                /*tp_finalize*/
 #endif
 #if PY_VERSION_HEX >= 0x030800b1

--- a/tests/pypy_bugs.txt
+++ b/tests/pypy_bugs.txt
@@ -57,6 +57,7 @@ run.async_iter_pep492
 run.embedsignatures
 run.py35_asyncio_async_def
 run.asyncio_generators
+run.py35_pep492_interop

 # gc issue?
 external_ref_reassignment

--- a/tests/pypy_crash_bugs.txt
+++ b/tests/pypy_crash_bugs.txt
@@ -5,9 +5,5 @@
 run.fastcall
 memslice

-# """Fatal RPython error: NotImplementedError
-# Aborted (core dumped)"""
-run.py35_pep492_interop
-
 # gc issue?
 memoryview_in_subclasses