This is really a hack, which may be integrated into renderJS directly

Reduce potential Zelenium test timeout by waiting for iframe to be loaded one by one

This check got lost when the first isSubtreeIndexable call was done on
parent document and not on self.

This partially reverts:

commit 76e3c115
Author: Vincent Pelletier <vincent@nexedi.com>
Date:   Mon Dec 10 16:40:48 2018 +0900

    Base: Fix isAncestryIndexable implementation.

as it accidentally carried over a totally unrelated (and unfinished)
change.

Start checking isSubtreeIndexable on parent document, not on current
document.
This bug broke Trash Bins indexation (and should not affect anything else,
as only Trash Bins prevent content indexation currently).

Extent trash tool unit test to verify actual indexation, and not just
indexability API.

Fixup nexedi/erp5@559c5e8b

See nexedi/erp5@994d8369

/reviewed-on nexedi/erp5!768

This should be tested even if it currently fails with "The operation is insecure"
when trying to upload local ODS files.

erp5_configurator_standard_ui_test: Fix testFunctionalConfigurator failures with erp5testnode (b955dbe0).

The following error occurred because setupAutomaticBusinessTemplateRepository()
was called and only added bt5/ directory but not bootstrap bt5s directory:
  BusinessTemplateMissingDependency: While analysing erp5_dhtml_style the following dependency could not be satisfied: erp5_xhtml_style ()
  Reason: Business Template could not be found in the repositories

Instead assume that bt5 repositories are set up properly.

Also, running through erp5testnode requires apache-backend Timeout to be
increased as waiting for upgrader activities to be processed can take
~15 minutes (!377).

[erp5_core] Follow guidelines for Actions on portal types Catalog and Catalog Tool by adding dialog before executing

Also, Cleanup useless actions and functions

/reviewed-on !811

* Assorted small fixes so that form comply to conventions
* Minimal fixes of invalid html
* make `mixin` usable in type definition 

The context is I was working on a custom configurator involving some matrixboxs, so I needed a simple business configuration item just to store the matrix result. This was possible with mixin, I just made a portal type based on Item class, enabling mxins for `Matrix` and `BusinessConfiguratorItem` and I did not have to define a class ( not sure this is really better ).

Then the matrixbox was not rendering properly, because browser was confused by the broken html and build a "different DOM" and selectors did not apply. This is what `configurator: fix (a bit) invalid HTML` addresses.

While doing this, fix some minor problems found with forms.

/reviewed-on nexedi/erp5!814

Insert fields in a <div>, not in a <table>, fields are not valid table
elements (they are not <tr>).

Configurator still produce invalid HTML, this seem to be the minimal fix
to have matrixboxs rendered properly without having to rewriting all
configurator page templates.

So that all string fields have same width

If user still has a cookie from a previous run this this will cause
problems.

This is a dirty workaround. Why configurator has to use cookies ?

https://www.erp5.com/erp5-HowTo.Create.Action.Dialogs
> The action must use an intermediate dialog, where the user can enter parameters.

Also allow to set a name for the business configuration that will be
created.

 * fix typo in column name
 * add editable field for correct display

I'm not sure this workflow is used, just fix the transition which were
using non existant dialog or wrong transitions names.

... otherwise when nothing is selected it looks like something is set.

Also translate and sort output.

Slapos build does not seem to support gif.

* it should be a *list* mode listbox (it was a view mode)
* listbox column title should be the portal type name ( no written rule for this apparently )
* listbox title should be plural of portal type https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#set-listbox-title-to-plural-of-portal-type-title-if-applicable

my_view_mode_listbox_configuration_save should use my_view_mode_listbox as target, not my_list_mode_listbox

https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#place-simulation-and-validation-fields-at-bottom-of-right-group

/reviewed-on nexedi/erp5!810

As source reference is the public reference of the Mandates (ie: RUM in the case of SEPA debits), it is even more useful than the simple reference

also disble in testI18NSearch the test which depends on catalog_full_text

Tests: do not depend on previous test executions.

See nexedi/erp5@cfa45fd8

Shamelessly copy Listbox.py implementation, which limits acquisition usage

For compatibility, do not check local properties when the listbox uses contentValues (ListMethodWrapper).

Keeping the browser's back button usable is a requirement to keep users happy.

First,  cleanup `testERPSecurity`, moving related tests in sub-classes instead of big classes with lots of tests (diff is big, because methods are moved around)

Change google and facebook login to reuse `portal.setAuthCookie`, which is the central point to set a cookie securely so that it can be used for authentication.

Refactor management of oauth keys to fix [#20181121-1A36AE2](https://nexedi.erp5.net/bug_module/20181121-1A36AE2).

Some minor fixes in business template definition.

/reviewed-on nexedi/erp5!803

Originally, there was a regression introduce in my recent changes that "Comment Author" column was always empty.

This MR contains some more refactoring for "Comment Date" and "Comment Author" columns:

![image](/uploads/7b07a6a5610d533f1435af45b3716104/image.png)

On the visible side, "Comment Date" column has been simplified, it used to show "hour:minutes" if the message was posted today, and "year/month/day" if the post was older. It's now a simple date time field (using `Base_viewCRMFieldLibrary/my_event_start_date`), for consistency.

On the implementation side, they now use existing `SupportRequest_getCommentPostListAsJson` script, which simplified code a lot. That script was also renamed as `SupportRequest_getCommentPostList`, because it's no longer returning JSON.

/reviewed-on nexedi/erp5!804

Some tickets (for example Support Request or Bugs) are focus on one small thing being discussed where usually a small number of events are posted.

Unlike for example  a campaign where there is a large number of events sent to a large number of recipients, in the case of these "small, self contained" tickets, it makes a lot of sense to see that the ticket was modified when a new event is posted on this ticket.

This is what we sometimes customize in some support request fast input. It was the case in Support Request App, but this was removed in 74fc68a7 , this time it's done at a lower level and such customisations are no longer needed.

/reviewed-on nexedi/erp5!807

Because this was displaying all worklists from ticket_worklist, which is
also used for all tickets (including for example Campaigns) and that
displaying other kind of tickets that Support Request is not supported
on this app, we should filter the worklists to display only support requests.

/reviewed-on nexedi/erp5!808