- 05 Apr, 2016 34 commits
-
-
Stan Hu authored
Fix Error 500 after renaming a project path Renaming the path of a project would result in an Error 500 due to `@repository` being memoized with the old path. An Error 500 would result: ``` Started GET "/testing2/test1" for 127.0.0.1 at 2016-04-04 12:42:30 +0000 Processing by ProjectsController#show as HTML Parameters: {"namespace_id"=>"testing2", "id"=>"test1"} Completed 200 OK in 637ms (Views: 194.2ms | ActiveRecord: 111.8ms) Started GET "/testing2/test1/edit" for 127.0.0.1 at 2016-04-04 12:42:33 +0000 Processing by ProjectsController#edit as HTML Parameters: {"namespace_id"=>"testing2", "id"=>"test1"} Completed 200 OK in 594ms (Views: 183.8ms | ActiveRecord: 87.4ms) Started PATCH "/testing2/test1" for 127.0.0.1 at 2016-04-04 12:42:41 +0000 Processing by ProjectsController#update as HTML Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "project"=>{"nam e"=>"test123", "path"=>"test123"}, "namespace_id"=>"testing2", "id"=>"test1"} Completed 500 Internal Server Error in 1852ms (ActiveRecord: 124.0ms) ActionView::Template::Error (no repository for such path): 2: %legend 3: Builds: 4: 5: - unless @repository.gitlab_ci_yml 6: .form-group 7: .col-sm-offset-2.col-sm-10 8: %p Builds need to be configured before you can begin using Contin uous Integration. app/models/repository.rb:59:in `block in empty?' lib/repository_cache.rb:19:in `fetch' app/models/repository.rb:59:in `empty?' app/models/repository.rb:471:in `gitlab_ci_yml' app/views/projects/_builds_settings.html.haml:5:in `_app_views_projects__build s_settings_html_haml__782034335636359229_73397600' app/views/projects/edit.html.haml:87:in `block in _app_views_projects_edit_htm l_haml___2388082585934859365_47390860' app/views/projects/edit.html.haml:8:in `_app_views_projects_edit_html_haml___2 388082585934859365_47390860' app/controllers/projects_controller.rb:54:in `block (2 levels) in update' app/controllers/projects_controller.rb:43:in `update' lib/gitlab/middleware/go.rb:16:in `call' ``` Closes #14885 See merge request !3528
-
Robert Speicher authored
Premailer shouldn't remove script tags from our emails Closes #14943. See merge request !3552
-
Robert Speicher authored
[ci skip]
-
Robert Speicher authored
Closes #14943.
-
Jacob Schatz authored
Fix data check in update issue response See merge request !3548
-
Annabel Dunstone authored
-
Jacob Schatz authored
Dropdown arrow support When the dropdown is open, you can scroll through the list of items with the up & down arrow keys. When an item is focused, the enter triggers the click event for that row. Closes #14455 See merge request !3385
-
Jacob Schatz authored
Notes form design update Part of #3401 See merge request !3442
-
Annabel Dunstone authored
-
Stan Hu authored
Closes #14885
-
Robert Speicher authored
[ci skip]
-
Sytse Sijbrandij authored
Attribution where it is due. Inspired by https://news.ycombinator.com/item?id=11431969 See merge request !3546
-
Robert Speicher authored
Upgrade bundler-audit from 0.4.0 to 0.5.0 Bundler Audit can now run the `check` command with an `—update` flag to update the Ruby CVE repository before checking. This removes the need for two separate commands in GitLab CI ([source](https://github.com/rubysec/bundler-audit#synopsis)). See the Changelog for more information: https://github.com/rubysec/bundler-audit/blob/master/ChangeLog.md#050--2015-02-28 See merge request !3433
-
Sytse Sijbrandij authored
-
Douwe Maan authored
Check permissions when importing project members Closes #14899 See merge request !3535
-
Rémy Coutable authored
[ci skip] Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
[ci skip] Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Achilleas Pipinellis authored
Fix LDAP link and codeblock indentation See merge request !3538
-
Achilleas Pipinellis authored
[ci skip]
-
Yorick Peterse authored
Update language after doing all other operations See merge request !3533
-
Jacob Schatz authored
Added CHANGELOG for build notifications [ci skip] See merge request !3537
-
Grzegorz Bizon authored
-
Phil Hughes authored
[ci skip]
-
Jacob Schatz authored
Add comments to the SCSS Lint config file [ci skip] This MR also adds some previously missing linters. See merge request !3500
-
Grzegorz Bizon authored
When importing members, and user does not have permissions to read members in a source project, do not leak information about source project existence. Notifiy user that project has not been found instead.
-
Jacob Schatz authored
Add missing changelog item about improving navigation sidebar Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> For !3494 and #14838 See merge request !3527
-
Grzegorz Bizon authored
Closes #14899
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Yorick Peterse authored
Fix Importing repos from GHE doesn't work See merge request !3529
-
Phil Hughes authored
-
Phil Hughes authored
-
Robert Speicher authored
Add link to image URL for images in discussions. The main problem with this is that it doesn't apply retroactively, only to images that are uploaded after this change. It's also hacky and probably not the most optimal solution. Resolves #14411. See merge request !3464
-
connorshea authored
Resolves #14411. See merge request !3464
-
- 04 Apr, 2016 6 commits
-
-
connorshea authored
Also add some previously missing linters.
-
Jacob Schatz authored
Remove 2FA status on enable page The 2FA status on the enabling page is useless, since it always is `disabled`. A user is enabling 2FA, so he already knows that it is disabled. ### Before ![Screenshot_2016-03-29_12.41.27](/uploads/4800a13a82f176077a11ecaf13ed0cb1/Screenshot_2016-03-29_12.41.27.png) ### After ![Screenshot_2016-03-29_12.40.55](/uploads/a77e8acd7cf99190bbd6bd340542ad10/Screenshot_2016-03-29_12.40.55.png) See merge request !3436
-
Douglas Barbosa Alexandre authored
GitHub Pull Requests importer handle with the repository while importing data, we need to make sure that the cached values are valid.
-
Dmitriy Zaporozhets authored
Improve UI for admin/groups page Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> cc @jschatz1 @skyruler See merge request !3523
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-