Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gosqlite
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gosqlite
Commits
c7891c1b
Commit
c7891c1b
authored
Jan 13, 2014
by
gwenn
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check statement column count is consistent.
parent
bf209594
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
28 additions
and
3 deletions
+28
-3
sqlite.go
sqlite.go
+11
-1
stmt.go
stmt.go
+9
-0
stmt_test.go
stmt_test.go
+8
-2
No files found.
sqlite.go
View file @
c7891c1b
...
...
@@ -350,7 +350,14 @@ func (c *Conn) Exists(query string, args ...interface{}) (bool, error) {
return
false
,
err
}
defer
s
.
Finalize
()
return
s
.
Next
()
ok
,
err
:=
s
.
Next
()
if
err
!=
nil
{
return
false
,
err
}
if
s
.
ColumnCount
()
==
0
{
return
false
,
s
.
specificError
(
"don't use Exists with query that returns no data such as %q"
,
query
)
}
return
ok
,
nil
}
// OneValue is used with SELECT that returns only one row with only one column.
...
...
@@ -366,6 +373,9 @@ func (c *Conn) OneValue(query string, value interface{}, args ...interface{}) er
if
err
!=
nil
{
return
err
}
else
if
!
b
{
if
s
.
ColumnCount
()
==
0
{
return
s
.
specificError
(
"don't use OneValue with query that returns no data such as %q"
,
query
)
}
return
io
.
EOF
}
return
s
.
Scan
(
value
)
...
...
stmt.go
View file @
c7891c1b
...
...
@@ -163,6 +163,9 @@ func (s *Stmt) exec() error {
}
return
s
.
error
(
rv
,
"Stmt.exec"
)
}
if
s
.
ColumnCount
()
>
0
{
return
s
.
specificError
(
"don't use exec with anything that returns data such as %q"
,
s
.
SQL
())
}
return
nil
}
...
...
@@ -211,6 +214,9 @@ func (s *Stmt) Select(rowCallbackHandler func(s *Stmt) error, args ...interface{
return
err
}
}
if
s
.
ColumnCount
()
==
0
{
return
s
.
specificError
(
"don't use Select with query that returns no data such as %q"
,
s
.
SQL
())
}
for
{
if
ok
,
err
:=
s
.
Next
();
err
!=
nil
{
return
err
...
...
@@ -233,6 +239,9 @@ func (s *Stmt) SelectOneRow(args ...interface{}) (bool, error) {
if
ok
,
err
:=
s
.
Next
();
err
!=
nil
{
return
false
,
err
}
else
if
!
ok
{
if
s
.
ColumnCount
()
==
0
{
return
false
,
s
.
specificError
(
"don't use SelectOneRow with query that returns no data such as %q"
,
s
.
SQL
())
}
return
false
,
nil
}
return
true
,
s
.
Scan
(
args
...
)
...
...
stmt_test.go
View file @
c7891c1b
...
...
@@ -291,8 +291,14 @@ func TestStmtSelectWithInsert(t *testing.T) {
defer
s
.
Finalize
()
exists
,
err
:=
s
.
SelectOneRow
()
checkNoError
(
t
,
err
,
"SELECT error: %s"
)
assert
.
T
(
t
,
!
exists
,
"no row expected"
)
assert
.
T
(
t
,
err
!=
nil
,
"error expected"
)
//println(err.Error())
if
serr
,
ok
:=
err
.
(
*
StmtError
);
ok
{
assert
.
Equal
(
t
,
ErrSpecific
,
serr
.
Code
())
}
else
{
t
.
Errorf
(
"Expected StmtError but got %s"
,
reflect
.
TypeOf
(
err
))
}
assert
.
T
(
t
,
!
exists
,
"false expected"
)
}
func
TestNamedBind
(
t
*
testing
.
T
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment