• Roopa Prabhu's avatar
    bridge: support for static fdb entries · a1987cd1
    Roopa Prabhu authored
    There is no intuitive option to add static fdb entries today.
    'temp' seems to have a side effect of adding
    'static' fdb entries. But the name and intent
    of 'temp' does not say anything about it being static.
    
    example:
    bridge fdb add operates as follows:
    
    $bridge fdb add 00:01:02:03:04:05 dev eth0 master
    $bridge fdb add 00:01:02:03:04:06 dev eth0 master temp
    $bridge fdb add 00:01:02:03:04:07 dev eth0 master local
    
    $bridge fdb show
    00:01:02:03:04:05 dev eth0 permanent
    00:01:02:03:04:06 dev eth0 static
    00:01:02:03:04:07 dev eth0 permanent
    00:01:02:03:04:08 dev eth0 <<== dynamic, ageable learned mac
    
    This patch adds a new bridge fdb type 'static' which
    makes sure NUD_NOARP and NUD_REACHABLE is set for static
    entries. This effectively is nothing but what 'temp'
    does today. But the name 'temp' is misleading.
    
    After the patch:
    $bridge fdb add 00:01:02:03:04:06 dev eth0 master static
    
    $bridge fdb show
    00:01:02:03:04:06 dev eth0 static
    
    'temp' could ideally be a dynamic mac that can age (ie just
    NUD_REACHABLE). But, 'temp' sets 'NUD_NOARP' and 'NUD_REACHABLE'.
    Too late to change 'temp' now. But, we are thinking of introduing a
    'dynamic' keyword after this patch that only sets NUD_REACHABLE.
    Signed-off-by: default avatarWilson Kok <wkok@cumulusnetworks.com>
    Signed-off-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
    a1987cd1
fdb.c 9.54 KB