L

linux

kirr's linux tree

  • Linus Torvalds's avatar
    scsi: qla2xxx: remove incorrect sparse #ifdef · 4525c878
    Linus Torvalds authored
    The code to try to shut up sparse warnings about questionable locking
    didn't shut up sparse: it made the result not parse as valid C at all,
    since the end result now has a label with no statement.
    
    The proper fix is to just always lock the hardware, the same way Bart
    did in commit 8ae17876 ("scsi: qla2xxx: Simplify the functions for
    dumping firmware").  That avoids the whole problem with having locking
    that is not statically obvious.
    
    But in the meantime, just remove the incorrect attempt at trying to
    avoid a sparse warning that just made things worse.
    
    This was exposed by commit 3e6efab8 ("scsi: qla2xxx: Fix reset of
    MPI firmware"), very similarly to how commit cbb01c2f ("scsi:
    qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem
    in another place, and caused that commit 8ae17876.
    
    Please don't add code to just shut up sparse without actually fixing
    what sparse complains about.
    Reported-by: 's avatarLuc Van Oostenryck <luc.vanoostenryck@gmail.com>
    Cc: Bart Van Assche <bvanassche@acm.org>
    Cc: Arun Easi <aeasi@marvell.com>
    Signed-off-by: 's avatarLinus Torvalds <torvalds@linux-foundation.org>
    4525c878
Name
Last commit
Last update
Documentation Loading commit data...
LICENSES Loading commit data...
arch Loading commit data...
block Loading commit data...
certs Loading commit data...
crypto Loading commit data...
drivers Loading commit data...
fs Loading commit data...
include Loading commit data...
init Loading commit data...
ipc Loading commit data...
kernel Loading commit data...
lib Loading commit data...
mm Loading commit data...
net Loading commit data...
samples Loading commit data...
scripts Loading commit data...
security Loading commit data...
sound Loading commit data...
tools Loading commit data...
usr Loading commit data...
virt Loading commit data...
.clang-format Loading commit data...
.cocciconfig Loading commit data...
.get_maintainer.ignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
Kbuild Loading commit data...
Kconfig Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README Loading commit data...