Commit 00b4bac7 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

media: imx274: don't randomly return if range_count is zero

As smatch reported:
	drivers/media/i2c/imx274.c:659 imx274_regmap_util_write_table_8() error: uninitialized symbol 'err'.

There is a bug at imx274_regmap_util_write_table_8() with causes
it to randomly return a random error if range_count is zero.

Worse than that, the logic there starts with range_count
equal to zero, and periodically resets it to zero again.

As it is a way more likely that err assumes a non-zero value,
I suspect that the chance of this code to run is very small,
so, it would be worth to review the entire function.

Anyway, clearly it shouldn't be returning error if range_count
is zero. So, let's fix it.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent ab0625f0
...@@ -655,6 +655,8 @@ static int imx274_regmap_util_write_table_8(struct regmap *regmap, ...@@ -655,6 +655,8 @@ static int imx274_regmap_util_write_table_8(struct regmap *regmap,
err = regmap_bulk_write(regmap, range_start, err = regmap_bulk_write(regmap, range_start,
&range_vals[0], &range_vals[0],
range_count); range_count);
else
err = 0;
if (err) if (err)
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment