Commit 02d9be1a authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina

HID: picoLCD: fix a NULL test in picolcd_raw_cir()

Smatch complains that the NULL checking in this function is not
consistent and could lead to a NULL dereference.  The comments say that
we should return here if rc_dev is NULL so I've changed the test to
match the comment.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent eb9001cd
...@@ -51,7 +51,7 @@ int picolcd_raw_cir(struct picolcd_data *data, ...@@ -51,7 +51,7 @@ int picolcd_raw_cir(struct picolcd_data *data,
/* ignore if rc_dev is NULL or status is shunned */ /* ignore if rc_dev is NULL or status is shunned */
spin_lock_irqsave(&data->lock, flags); spin_lock_irqsave(&data->lock, flags);
if (data->rc_dev && (data->status & PICOLCD_CIR_SHUN)) { if (!data->rc_dev || (data->status & PICOLCD_CIR_SHUN)) {
spin_unlock_irqrestore(&data->lock, flags); spin_unlock_irqrestore(&data->lock, flags);
return 1; return 1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment