Commit 04b2550a authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Luis Henriques

dm log userspace: fix memory leak in dm_ulog_tfr_init failure path

commit 56ec16cb upstream.

If cn_add_callback() fails in dm_ulog_tfr_init(), it does not
deallocate prealloced memory but calls cn_del_callback().

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: default avatarJonathan Brassow <jbrassow@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 4296b616
...@@ -272,7 +272,7 @@ int dm_ulog_tfr_init(void) ...@@ -272,7 +272,7 @@ int dm_ulog_tfr_init(void)
r = cn_add_callback(&ulog_cn_id, "dmlogusr", cn_ulog_callback); r = cn_add_callback(&ulog_cn_id, "dmlogusr", cn_ulog_callback);
if (r) { if (r) {
cn_del_callback(&ulog_cn_id); kfree(prealloced_cn_msg);
return r; return r;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment