Commit 06cd7423 authored by Shixin Liu's avatar Shixin Liu Committed by Herbert Xu

crypto: sun8i-ss - Fix PM reference leak when pm_runtime_get_sync() fails

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Signed-off-by: default avatarShixin Liu <liushixin2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ac98fc5e
...@@ -354,7 +354,7 @@ int sun8i_ss_cipher_init(struct crypto_tfm *tfm) ...@@ -354,7 +354,7 @@ int sun8i_ss_cipher_init(struct crypto_tfm *tfm)
op->enginectx.op.prepare_request = NULL; op->enginectx.op.prepare_request = NULL;
op->enginectx.op.unprepare_request = NULL; op->enginectx.op.unprepare_request = NULL;
err = pm_runtime_get_sync(op->ss->dev); err = pm_runtime_resume_and_get(op->ss->dev);
if (err < 0) { if (err < 0) {
dev_err(op->ss->dev, "pm error %d\n", err); dev_err(op->ss->dev, "pm error %d\n", err);
goto error_pm; goto error_pm;
......
...@@ -753,7 +753,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) ...@@ -753,7 +753,7 @@ static int sun8i_ss_probe(struct platform_device *pdev)
if (err) if (err)
goto error_alg; goto error_alg;
err = pm_runtime_get_sync(ss->dev); err = pm_runtime_resume_and_get(ss->dev);
if (err < 0) if (err < 0)
goto error_alg; goto error_alg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment