Commit 075718fd authored by Xin Long's avatar Xin Long Committed by David S. Miller

sctp: fix transport encap_port update in sctp_vtag_verify

transport encap_port update should be updated when sctp_vtag_verify()
succeeds, namely, returns 1, not returns 0. Correct it in this patch.

While at it, also fix the indentation.

Fixes: a1dd2cf2 ("sctp: allow changing transport encap_port by peer packets")
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c2402d43
...@@ -384,11 +384,11 @@ sctp_vtag_verify(const struct sctp_chunk *chunk, ...@@ -384,11 +384,11 @@ sctp_vtag_verify(const struct sctp_chunk *chunk,
* Verification Tag value does not match the receiver's own * Verification Tag value does not match the receiver's own
* tag value, the receiver shall silently discard the packet... * tag value, the receiver shall silently discard the packet...
*/ */
if (ntohl(chunk->sctp_hdr->vtag) == asoc->c.my_vtag) if (ntohl(chunk->sctp_hdr->vtag) != asoc->c.my_vtag)
return 1; return 0;
chunk->transport->encap_port = SCTP_INPUT_CB(chunk->skb)->encap_port; chunk->transport->encap_port = SCTP_INPUT_CB(chunk->skb)->encap_port;
return 0; return 1;
} }
/* Check VTAG of the packet matches the sender's own tag and the T bit is /* Check VTAG of the packet matches the sender's own tag and the T bit is
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment