Commit 084c3ff1 authored by Wu Hao's avatar Wu Hao Committed by Moritz Fischer

fpga: dfl: fme: convert platform_driver to use dev_groups

This patch takes advantage of driver core which helps to create
and remove sysfs attribute files, so there is no need to register
sysfs entries manually in dfl-fme platform river code.
Signed-off-by: default avatarWu Hao <hao.wu@intel.com>
Acked-by: default avatarMoritz Fischer <mdf@kernel.org>
Signed-off-by: default avatarMoritz Fischer <mdf@kernel.org>
parent 84b693e3
...@@ -129,30 +129,6 @@ static struct attribute *fme_hdr_attrs[] = { ...@@ -129,30 +129,6 @@ static struct attribute *fme_hdr_attrs[] = {
}; };
ATTRIBUTE_GROUPS(fme_hdr); ATTRIBUTE_GROUPS(fme_hdr);
static int fme_hdr_init(struct platform_device *pdev,
struct dfl_feature *feature)
{
void __iomem *base = feature->ioaddr;
int ret;
dev_dbg(&pdev->dev, "FME HDR Init.\n");
dev_dbg(&pdev->dev, "FME cap %llx.\n",
(unsigned long long)readq(base + FME_HDR_CAP));
ret = device_add_groups(&pdev->dev, fme_hdr_groups);
if (ret)
return ret;
return 0;
}
static void fme_hdr_uinit(struct platform_device *pdev,
struct dfl_feature *feature)
{
dev_dbg(&pdev->dev, "FME HDR UInit.\n");
device_remove_groups(&pdev->dev, fme_hdr_groups);
}
static long fme_hdr_ioctl_release_port(struct dfl_feature_platform_data *pdata, static long fme_hdr_ioctl_release_port(struct dfl_feature_platform_data *pdata,
unsigned long arg) unsigned long arg)
{ {
...@@ -199,8 +175,6 @@ static const struct dfl_feature_id fme_hdr_id_table[] = { ...@@ -199,8 +175,6 @@ static const struct dfl_feature_id fme_hdr_id_table[] = {
}; };
static const struct dfl_feature_ops fme_hdr_ops = { static const struct dfl_feature_ops fme_hdr_ops = {
.init = fme_hdr_init,
.uinit = fme_hdr_uinit,
.ioctl = fme_hdr_ioctl, .ioctl = fme_hdr_ioctl,
}; };
...@@ -362,6 +336,7 @@ static int fme_remove(struct platform_device *pdev) ...@@ -362,6 +336,7 @@ static int fme_remove(struct platform_device *pdev)
static struct platform_driver fme_driver = { static struct platform_driver fme_driver = {
.driver = { .driver = {
.name = DFL_FPGA_FEATURE_DEV_FME, .name = DFL_FPGA_FEATURE_DEV_FME,
.dev_groups = fme_hdr_groups,
}, },
.probe = fme_probe, .probe = fme_probe,
.remove = fme_remove, .remove = fme_remove,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment