Commit 08921ac9 authored by Jesper Juhl's avatar Jesper Juhl Committed by Mauro Carvalho Chehab

[media] Media, DVB, Siano, smsusb: Avoid static analysis report about 'use after free'

In drivers/media/dvb/siano/smsusb.c we have this code:
 ...
               kfree(dev);

               sms_info("device %p destroyed", dev);
 ...

at least one static analysis tool (Coverity Prevent) complains about this
as a use-after-free bug.
While it's true that we do use the pointer variable after freeing it, the
only use is to print the value of the pointer, so there's not actually any
problem here. But still, silencing the complaint is trivial by just moving
the kfree() call below the sms_info(), so why not just do it?. It doesn't
change the workings of the code in any way, but it makes the tool shut up.
The patch below also removes a rather pointless blank line.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 792bc09a
...@@ -297,9 +297,8 @@ static void smsusb_term_device(struct usb_interface *intf) ...@@ -297,9 +297,8 @@ static void smsusb_term_device(struct usb_interface *intf)
if (dev->coredev) if (dev->coredev)
smscore_unregister_device(dev->coredev); smscore_unregister_device(dev->coredev);
kfree(dev);
sms_info("device %p destroyed", dev); sms_info("device %p destroyed", dev);
kfree(dev);
} }
usb_set_intfdata(intf, NULL); usb_set_intfdata(intf, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment