Commit 0a321b97 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Wolfram Sang

i2c: fsi: Add of_put_node() before break

Each iteration of for_each_available_childe_of_node puts the previous
node, but in the case of a break from the middle of the loop, there
is no put, thus causing a memory leak. Add an of_node_put before the
break.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Reviewed-by: default avatarEddie James <eajames@linux.ibm.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 7077ad2e
...@@ -707,8 +707,10 @@ static int fsi_i2c_probe(struct device *dev) ...@@ -707,8 +707,10 @@ static int fsi_i2c_probe(struct device *dev)
continue; continue;
port = kzalloc(sizeof(*port), GFP_KERNEL); port = kzalloc(sizeof(*port), GFP_KERNEL);
if (!port) if (!port) {
of_node_put(np);
break; break;
}
port->master = i2c; port->master = i2c;
port->port = port_no; port->port = port_no;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment