Commit 0fd6e121 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab

media: cec: set ev rather than v with CEC_PIN_EVENT_FL_DROPPED bit

Setting v with the CEC_PIN_EVENT_FL_DROPPED is incorrect, instead
ev should be set with this bit. Fix this.

Detected by CoverityScan, CID#1467974 ("Extra high-order bits")

Fixes: 6ec1cbf6 ("media: cec: improve CEC pin event handling")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 29e61d6e
...@@ -119,7 +119,7 @@ static void cec_pin_update(struct cec_pin *pin, bool v, bool force) ...@@ -119,7 +119,7 @@ static void cec_pin_update(struct cec_pin *pin, bool v, bool force)
if (pin->work_pin_events_dropped) { if (pin->work_pin_events_dropped) {
pin->work_pin_events_dropped = false; pin->work_pin_events_dropped = false;
v |= CEC_PIN_EVENT_FL_DROPPED; ev |= CEC_PIN_EVENT_FL_DROPPED;
} }
pin->work_pin_events[pin->work_pin_events_wr] = ev; pin->work_pin_events[pin->work_pin_events_wr] = ev;
pin->work_pin_ts[pin->work_pin_events_wr] = ktime_get(); pin->work_pin_ts[pin->work_pin_events_wr] = ktime_get();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment