Commit 111fbc68 authored by Fabian Frederick's avatar Fabian Frederick Committed by Benjamin Herrenschmidt

powerpc/pmac: replace current->state by set_current_state()

Use helper functions to access current->state.
Direct assignments are prone to races and therefore buggy.

current->state = TASK_RUNNING can be replaced by __set_current_state()

Thanks to Peter Zijlstra for the exact definition of the problem.
Suggested-By: default avatarPeter Zijlstra <peterz@infradead.org>
Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 1f8c82ab
...@@ -2112,7 +2112,7 @@ pmu_read(struct file *file, char __user *buf, ...@@ -2112,7 +2112,7 @@ pmu_read(struct file *file, char __user *buf,
spin_lock_irqsave(&pp->lock, flags); spin_lock_irqsave(&pp->lock, flags);
add_wait_queue(&pp->wait, &wait); add_wait_queue(&pp->wait, &wait);
current->state = TASK_INTERRUPTIBLE; set_current_state(TASK_INTERRUPTIBLE);
for (;;) { for (;;) {
ret = -EAGAIN; ret = -EAGAIN;
...@@ -2141,7 +2141,7 @@ pmu_read(struct file *file, char __user *buf, ...@@ -2141,7 +2141,7 @@ pmu_read(struct file *file, char __user *buf,
schedule(); schedule();
spin_lock_irqsave(&pp->lock, flags); spin_lock_irqsave(&pp->lock, flags);
} }
current->state = TASK_RUNNING; __set_current_state(TASK_RUNNING);
remove_wait_queue(&pp->wait, &wait); remove_wait_queue(&pp->wait, &wait);
spin_unlock_irqrestore(&pp->lock, flags); spin_unlock_irqrestore(&pp->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment