Commit 11516135 authored by Andrey Konovalov's avatar Andrey Konovalov Committed by Linus Torvalds

kasan: add a test for kmem_cache_alloc/free_bulk

Add a test for kmem_cache_alloc/free_bulk to make sure there are no
false-positives when these functions are used.

Link: https://linux-review.googlesource.com/id/I2a8bf797aecf81baeac61380c567308f319e263d
Link: https://lkml.kernel.org/r/418122ebe4600771ac81e9ca6eab6740cf8dcfa1.1610733117.git.andreyknvl@google.comSigned-off-by: default avatarAndrey Konovalov <andreyknvl@google.com>
Reviewed-by: default avatarMarco Elver <elver@google.com>
Reviewed-by: default avatarAlexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Branislav Rankov <Branislav.Rankov@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Evgenii Stepanov <eugenis@google.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: Peter Collingbourne <pcc@google.com>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 858bdeb0
...@@ -479,10 +479,11 @@ static void kmem_cache_oob(struct kunit *test) ...@@ -479,10 +479,11 @@ static void kmem_cache_oob(struct kunit *test)
{ {
char *p; char *p;
size_t size = 200; size_t size = 200;
struct kmem_cache *cache = kmem_cache_create("test_cache", struct kmem_cache *cache;
size, 0,
0, NULL); cache = kmem_cache_create("test_cache", size, 0, 0, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache);
p = kmem_cache_alloc(cache, GFP_KERNEL); p = kmem_cache_alloc(cache, GFP_KERNEL);
if (!p) { if (!p) {
kunit_err(test, "Allocation failed: %s\n", __func__); kunit_err(test, "Allocation failed: %s\n", __func__);
...@@ -491,11 +492,12 @@ static void kmem_cache_oob(struct kunit *test) ...@@ -491,11 +492,12 @@ static void kmem_cache_oob(struct kunit *test)
} }
KUNIT_EXPECT_KASAN_FAIL(test, *p = p[size + OOB_TAG_OFF]); KUNIT_EXPECT_KASAN_FAIL(test, *p = p[size + OOB_TAG_OFF]);
kmem_cache_free(cache, p); kmem_cache_free(cache, p);
kmem_cache_destroy(cache); kmem_cache_destroy(cache);
} }
static void memcg_accounted_kmem_cache(struct kunit *test) static void kmem_cache_accounted(struct kunit *test)
{ {
int i; int i;
char *p; char *p;
...@@ -522,6 +524,31 @@ static void memcg_accounted_kmem_cache(struct kunit *test) ...@@ -522,6 +524,31 @@ static void memcg_accounted_kmem_cache(struct kunit *test)
kmem_cache_destroy(cache); kmem_cache_destroy(cache);
} }
static void kmem_cache_bulk(struct kunit *test)
{
struct kmem_cache *cache;
size_t size = 200;
char *p[10];
bool ret;
int i;
cache = kmem_cache_create("test_cache", size, 0, 0, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache);
ret = kmem_cache_alloc_bulk(cache, GFP_KERNEL, ARRAY_SIZE(p), (void **)&p);
if (!ret) {
kunit_err(test, "Allocation failed: %s\n", __func__);
kmem_cache_destroy(cache);
return;
}
for (i = 0; i < ARRAY_SIZE(p); i++)
p[i][0] = p[i][size - 1] = 42;
kmem_cache_free_bulk(cache, ARRAY_SIZE(p), (void **)&p);
kmem_cache_destroy(cache);
}
static char global_array[10]; static char global_array[10];
static void kasan_global_oob(struct kunit *test) static void kasan_global_oob(struct kunit *test)
...@@ -961,7 +988,8 @@ static struct kunit_case kasan_kunit_test_cases[] = { ...@@ -961,7 +988,8 @@ static struct kunit_case kasan_kunit_test_cases[] = {
KUNIT_CASE(kfree_via_page), KUNIT_CASE(kfree_via_page),
KUNIT_CASE(kfree_via_phys), KUNIT_CASE(kfree_via_phys),
KUNIT_CASE(kmem_cache_oob), KUNIT_CASE(kmem_cache_oob),
KUNIT_CASE(memcg_accounted_kmem_cache), KUNIT_CASE(kmem_cache_accounted),
KUNIT_CASE(kmem_cache_bulk),
KUNIT_CASE(kasan_global_oob), KUNIT_CASE(kasan_global_oob),
KUNIT_CASE(kasan_stack_oob), KUNIT_CASE(kasan_stack_oob),
KUNIT_CASE(kasan_alloca_oob_left), KUNIT_CASE(kasan_alloca_oob_left),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment