Commit 11a247e3 authored by Michael Holzheu's avatar Michael Holzheu Committed by Martin Schwidefsky

s390: Remove VLAIS in ptff() and clear_table()

The ptff() and clear_table() functions use the gcc extension "variable
length arrays in structures" (VLAIS) to define in the inline assembler
constraints the area of the clobbered memory. This extension will most
likely never be supported by LLVM/Clang.

Since currently BPF programs are compiled with LLVM, this leads to the
following compile errors:

 $ cd samples/bpf
 $ make

 In file included from /root/linux-master/samples/bpf/tracex1_kern.c:8:
 In file included from ./include/linux/netdevice.h:44:
 ...
 In file included from ./arch/s390/include/asm/mmu_context.h:10:
  ./arch/s390/include/asm/pgalloc.h:30:24: error: fields must have a
  constant size: 'variable length array in structure' extension will never
  be supported
         typedef struct { char _[n]; } addrtype;

 In file included from /root/linux-master/samples/bpf/tracex1_kern.c:7:
 In file included from ./include/linux/skbuff.h:18:
 ...
 In file included from ./include/linux/jiffies.h:8:
 In file included from ./include/linux/timex.h:65:
  ./arch/s390/include/asm/timex.h:105:24: error: fields must have a
  constant size: 'variable length array in structure' extension will never
  be supported
        typedef struct { char _[len]; } addrtype;

To fix this do the following:

 - Convert ptff() into a macro that then uses a fixed size array
   when expanded.
 - Convert the clear_table() function and use an inline assembly
   with fixed size array in a loop.
   The runtime performance of the new version is even better than
   the old version (tested with EC12/z13 and gcc 4.8.5/6.2.1 with
   "-march=z196 -O2").
Reported-by: default avatarZvonko Kosic <zvonko.kosic@de.ibm.com>
Signed-off-by: default avatarMichael Holzheu <holzheu@linux.vnet.ibm.com>
Acked-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent ce4dda3f
...@@ -27,17 +27,17 @@ extern int page_table_allocate_pgste; ...@@ -27,17 +27,17 @@ extern int page_table_allocate_pgste;
static inline void clear_table(unsigned long *s, unsigned long val, size_t n) static inline void clear_table(unsigned long *s, unsigned long val, size_t n)
{ {
typedef struct { char _[n]; } addrtype; struct addrtype { char _[256]; };
int i;
for (i = 0; i < n; i += 256) {
*s = val; *s = val;
n = (n / 256) - 1;
asm volatile( asm volatile(
" mvc 8(248,%0),0(%0)\n" "mvc 8(248,%[s]),0(%[s])\n"
"0: mvc 256(256,%0),0(%0)\n" : "+m" (*(struct addrtype *) s)
" la %0,256(%0)\n" : [s] "a" (s));
" brct %1,0b\n" s += 256 / sizeof(long);
: "+a" (s), "+d" (n), "=m" (*(addrtype *) s) }
: "m" (*(addrtype *) s));
} }
static inline void crst_table_init(unsigned long *crst, unsigned long entry) static inline void crst_table_init(unsigned long *crst, unsigned long entry)
......
...@@ -98,21 +98,28 @@ struct ptff_qui { ...@@ -98,21 +98,28 @@ struct ptff_qui {
unsigned int pad_0x5c[41]; unsigned int pad_0x5c[41];
} __packed; } __packed;
static inline int ptff(void *ptff_block, size_t len, unsigned int func) /*
{ * ptff - Perform timing facility function
typedef struct { char _[len]; } addrtype; * @ptff_block: Pointer to ptff parameter block
register unsigned int reg0 asm("0") = func; * @len: Length of parameter block
register unsigned long reg1 asm("1") = (unsigned long) ptff_block; * @func: Function code
int rc; * Returns: Condition code (0 on success)
*/
asm volatile( #define ptff(ptff_block, len, func) \
" .word 0x0104\n" ({ \
" ipm %0\n" struct addrtype { char _[len]; }; \
" srl %0,28\n" register unsigned int reg0 asm("0") = func; \
: "=d" (rc), "+m" (*(addrtype *) ptff_block) register unsigned long reg1 asm("1") = (unsigned long) (ptff_block);\
: "d" (reg0), "d" (reg1) : "cc"); int rc; \
return rc; \
} asm volatile( \
" .word 0x0104\n" \
" ipm %0\n" \
" srl %0,28\n" \
: "=d" (rc), "+m" (*(struct addrtype *) reg1) \
: "d" (reg0), "d" (reg1) : "cc"); \
rc; \
})
static inline unsigned long long local_tick_disable(void) static inline unsigned long long local_tick_disable(void)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment