Commit 11d3d334 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Linus Walleij

gpio: dwapb: drop irq_setup_generic_chip()

The driver calls irq_alloc_domain_generic_chips() which creates a gc and
adds it to gc_list. The driver later then calls irq_setup_generic_chip()
which also initializes the gc and adds it to the gc_list() and this
corrupts the list. Enable LIST_DEBUG and you see the kernel complain.
This isn't required, irq_alloc_domain_generic_chips() did the init.
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: default avatarAlan Tull <delicious.quinoa@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a1415a8f
...@@ -260,9 +260,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, ...@@ -260,9 +260,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
ct->regs.ack = GPIO_PORTA_EOI; ct->regs.ack = GPIO_PORTA_EOI;
ct->regs.mask = GPIO_INTMASK; ct->regs.mask = GPIO_INTMASK;
irq_setup_generic_chip(irq_gc, IRQ_MSK(port->bgc.gc.ngpio),
IRQ_GC_INIT_NESTED_LOCK, IRQ_NOREQUEST, 0);
irq_set_chained_handler(irq, dwapb_irq_handler); irq_set_chained_handler(irq, dwapb_irq_handler);
irq_set_handler_data(irq, gpio); irq_set_handler_data(irq, gpio);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment