Commit 11f26633 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki

PM: suspend: Fix platform_suspend_prepare_noirq()

After commit ac9eafbe ("ACPI: PM: s2idle: Execute LPS0 _DSM
functions with suspended devices"), a NULL pointer may be dereferenced
if suspend-to-idle is attempted on a platform without "traditional"
suspend support due to invalid fall-through in
platform_suspend_prepare_noirq().

Fix that and while at it add missing braces in platform_resume_noirq().

Fixes: ac9eafbe ("ACPI: PM: s2idle: Execute LPS0 _DSM functions with suspended devices")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent d19bdb87
...@@ -253,10 +253,10 @@ static int platform_suspend_prepare_late(suspend_state_t state) ...@@ -253,10 +253,10 @@ static int platform_suspend_prepare_late(suspend_state_t state)
static int platform_suspend_prepare_noirq(suspend_state_t state) static int platform_suspend_prepare_noirq(suspend_state_t state)
{ {
if (state == PM_SUSPEND_TO_IDLE) { if (state == PM_SUSPEND_TO_IDLE)
if (s2idle_ops && s2idle_ops->prepare_late) return s2idle_ops && s2idle_ops->prepare_late ?
return s2idle_ops->prepare_late(); s2idle_ops->prepare_late() : 0;
}
return suspend_ops->prepare_late ? suspend_ops->prepare_late() : 0; return suspend_ops->prepare_late ? suspend_ops->prepare_late() : 0;
} }
...@@ -265,8 +265,9 @@ static void platform_resume_noirq(suspend_state_t state) ...@@ -265,8 +265,9 @@ static void platform_resume_noirq(suspend_state_t state)
if (state == PM_SUSPEND_TO_IDLE) { if (state == PM_SUSPEND_TO_IDLE) {
if (s2idle_ops && s2idle_ops->restore_early) if (s2idle_ops && s2idle_ops->restore_early)
s2idle_ops->restore_early(); s2idle_ops->restore_early();
} else if (suspend_ops->wake) } else if (suspend_ops->wake) {
suspend_ops->wake(); suspend_ops->wake();
}
} }
static void platform_resume_early(suspend_state_t state) static void platform_resume_early(suspend_state_t state)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment