Commit 126b75e0 authored by Alastair Bridgewater's avatar Alastair Bridgewater Committed by Takashi Iwai

ALSA: hda/ca0132: Don't test for QUIRK_NONE

QUIRK_NONE is, quite explicitly, the default case.  The entire
point of a quirks system is to allow "programming by difference"
from a given base case, which requires that merely defining a new
quirk for some piece of hardware should not change the behavior of
the driver for that hardware.  In turn, this means that testing
for QUIRK_NONE explicitly is a violation of that implicit contract.

Change a test for QUIRK_NONE and QUIRK_ALIENWARE to default, and
add a test for QUIRK_SBZ to disable the default behavior in that
instance.
Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 365c7f25
...@@ -7237,8 +7237,9 @@ static int ca0132_init(struct hda_codec *codec) ...@@ -7237,8 +7237,9 @@ static int ca0132_init(struct hda_codec *codec)
case QUIRK_R3DI: case QUIRK_R3DI:
r3di_setup_defaults(codec); r3di_setup_defaults(codec);
break; break;
case QUIRK_NONE: case QUIRK_SBZ:
case QUIRK_ALIENWARE: break;
default:
ca0132_setup_defaults(codec); ca0132_setup_defaults(codec);
ca0132_init_analog_mic2(codec); ca0132_init_analog_mic2(codec);
ca0132_init_dmic(codec); ca0132_init_dmic(codec);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment