Commit 12c2e32f authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

net: ethernet: bgmac: Fix return value check in bgmac_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cf81b2cc
...@@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev) ...@@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev)
} }
bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs); bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
if (!bgmac->plat.idm_base) { if (IS_ERR(bgmac->plat.idm_base)) {
dev_err(&pdev->dev, "Unable to map idm resource\n"); dev_err(&pdev->dev, "Unable to map idm resource\n");
return PTR_ERR(bgmac->plat.idm_base); return PTR_ERR(bgmac->plat.idm_base);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment