Commit 12f59080 authored by Tony Lindgren's avatar Tony Lindgren Committed by Vinod Koul

dmaengine: cppi41: Fix list not empty warning on module removal

If musb controller is configured with USB peripherals and we have
enumerated with a USB host, we can get warnings on removal of the
modules:

WARNING: CPU: 0 PID: 1269 at drivers/dma/cppi41.c:391
cppi41_dma_free_chan_resources

Fix the issue by adding the missing pm_runtime_get to
cppi41_dma_free_chan_resources to make sure the pending work
list is cleared on removal.

Fixes: fdea2d09 ("dmaengine: cppi41: Add basic PM runtime support")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent f732c5b7
...@@ -1072,7 +1072,12 @@ static int cppi41_dma_probe(struct platform_device *pdev) ...@@ -1072,7 +1072,12 @@ static int cppi41_dma_probe(struct platform_device *pdev)
static int cppi41_dma_remove(struct platform_device *pdev) static int cppi41_dma_remove(struct platform_device *pdev)
{ {
struct cppi41_dd *cdd = platform_get_drvdata(pdev); struct cppi41_dd *cdd = platform_get_drvdata(pdev);
int error;
error = pm_runtime_get_sync(&pdev->dev);
if (error < 0)
dev_err(&pdev->dev, "%s could not pm_runtime_get: %i\n",
__func__, error);
of_dma_controller_free(pdev->dev.of_node); of_dma_controller_free(pdev->dev.of_node);
dma_async_device_unregister(&cdd->ddev); dma_async_device_unregister(&cdd->ddev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment