Commit 15da7808 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Yao

drm/rockchip: fix a couple off by one bugs

The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should
be >= here.

Fixes: 2048e328 ('drm: rockchip: Add basic drm driver')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
parent 44958207
...@@ -79,7 +79,7 @@ int rockchip_register_crtc_funcs(struct drm_crtc *crtc, ...@@ -79,7 +79,7 @@ int rockchip_register_crtc_funcs(struct drm_crtc *crtc,
int pipe = drm_crtc_index(crtc); int pipe = drm_crtc_index(crtc);
struct rockchip_drm_private *priv = crtc->dev->dev_private; struct rockchip_drm_private *priv = crtc->dev->dev_private;
if (pipe > ROCKCHIP_MAX_CRTC) if (pipe >= ROCKCHIP_MAX_CRTC)
return -EINVAL; return -EINVAL;
priv->crtc_funcs[pipe] = crtc_funcs; priv->crtc_funcs[pipe] = crtc_funcs;
...@@ -92,7 +92,7 @@ void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc) ...@@ -92,7 +92,7 @@ void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc)
int pipe = drm_crtc_index(crtc); int pipe = drm_crtc_index(crtc);
struct rockchip_drm_private *priv = crtc->dev->dev_private; struct rockchip_drm_private *priv = crtc->dev->dev_private;
if (pipe > ROCKCHIP_MAX_CRTC) if (pipe >= ROCKCHIP_MAX_CRTC)
return; return;
priv->crtc_funcs[pipe] = NULL; priv->crtc_funcs[pipe] = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment