Commit 184416d4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Chuck Lever

NFSD: prevent underflow in nfssvc_decode_writeargs()

Smatch complains:

	fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
	warn: no lower bound on 'args->len'

Change the type to unsigned to prevent this issue.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 9d664776
...@@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp) ...@@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)
unsigned long cnt = argp->len; unsigned long cnt = argp->len;
unsigned int nvecs; unsigned int nvecs;
dprintk("nfsd: WRITE %s %d bytes at %d\n", dprintk("nfsd: WRITE %s %u bytes at %d\n",
SVCFH_fmt(&argp->fh), SVCFH_fmt(&argp->fh),
argp->len, argp->offset); argp->len, argp->offset);
......
...@@ -32,7 +32,7 @@ struct nfsd_readargs { ...@@ -32,7 +32,7 @@ struct nfsd_readargs {
struct nfsd_writeargs { struct nfsd_writeargs {
svc_fh fh; svc_fh fh;
__u32 offset; __u32 offset;
int len; __u32 len;
struct xdr_buf payload; struct xdr_buf payload;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment