Commit 188f513d authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen

scsi: isci: remote_node_table: Provide some missing params and remove others

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/isci/remote_node_table.c:113: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_clear_group_index'
 drivers/scsi/isci/remote_node_table.c:113: warning: Excess function parameter 'set_index' description in 'sci_remote_node_table_clear_group_index'
 drivers/scsi/isci/remote_node_table.c:262: warning: Function parameter or member 'group_index' not described in 'sci_remote_node_table_set_group'
 drivers/scsi/isci/remote_node_table.c:383: warning: Function parameter or member 'group_table_index' not described in 'sci_remote_node_table_allocate_single_remote_node'
 drivers/scsi/isci/remote_node_table.c:383: warning: Excess function parameter 'table_index' description in 'sci_remote_node_table_allocate_single_remote_node'
 drivers/scsi/isci/remote_node_table.c:516: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_single_remote_node'
 drivers/scsi/isci/remote_node_table.c:562: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_triple_remote_node'
 drivers/scsi/isci/remote_node_table.c:588: warning: Function parameter or member 'remote_node_index' not described in 'sci_remote_node_table_release_remote_node_index'

Link: https://lore.kernel.org/r/20210317091230.2912389-31-lee.jones@linaro.org
Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d2d480f1
...@@ -99,7 +99,7 @@ static u32 sci_remote_node_table_get_group_index( ...@@ -99,7 +99,7 @@ static u32 sci_remote_node_table_get_group_index(
* sci_remote_node_table_clear_group_index() * sci_remote_node_table_clear_group_index()
* @remote_node_table: This the remote node table in which to clear the * @remote_node_table: This the remote node table in which to clear the
* selector. * selector.
* @set_index: This is the remote node selector in which the change will be * @group_table_index: This is the remote node selector in which the change will be
* made. * made.
* @group_index: This is the bit index in the table to be modified. * @group_index: This is the bit index in the table to be modified.
* *
...@@ -250,9 +250,8 @@ static void sci_remote_node_table_clear_group( ...@@ -250,9 +250,8 @@ static void sci_remote_node_table_clear_group(
remote_node_table->available_remote_nodes[dword_location] = dword_value; remote_node_table->available_remote_nodes[dword_location] = dword_value;
} }
/** /*
* sci_remote_node_table_set_group() * sci_remote_node_table_set_group()
* @remote_node_table:
* *
* THis method sets an entire remote node group in the remote node table. * THis method sets an entire remote node group in the remote node table.
*/ */
...@@ -366,7 +365,7 @@ void sci_remote_node_table_initialize( ...@@ -366,7 +365,7 @@ void sci_remote_node_table_initialize(
* sci_remote_node_table_allocate_single_remote_node() * sci_remote_node_table_allocate_single_remote_node()
* @remote_node_table: The remote node table from which to allocate a * @remote_node_table: The remote node table from which to allocate a
* remote node. * remote node.
* @table_index: The group index that is to be used for the search. * @group_table_index: The group index that is to be used for the search.
* *
* This method will allocate a single RNi from the remote node table. The * This method will allocate a single RNi from the remote node table. The
* table index will determine from which remote node group table to search. * table index will determine from which remote node group table to search.
...@@ -426,7 +425,7 @@ static u16 sci_remote_node_table_allocate_single_remote_node( ...@@ -426,7 +425,7 @@ static u16 sci_remote_node_table_allocate_single_remote_node(
* sci_remote_node_table_allocate_triple_remote_node() * sci_remote_node_table_allocate_triple_remote_node()
* @remote_node_table: This is the remote node table from which to allocate the * @remote_node_table: This is the remote node table from which to allocate the
* remote node entries. * remote node entries.
* @group_table_index: THis is the group table index which must equal two (2) * @group_table_index: This is the group table index which must equal two (2)
* for this operation. * for this operation.
* *
* This method will allocate three consecutive remote node context entries. If * This method will allocate three consecutive remote node context entries. If
...@@ -506,7 +505,7 @@ u16 sci_remote_node_table_allocate_remote_node( ...@@ -506,7 +505,7 @@ u16 sci_remote_node_table_allocate_remote_node(
* sci_remote_node_table_release_single_remote_node() * sci_remote_node_table_release_single_remote_node()
* @remote_node_table: This is the remote node table from which the remote node * @remote_node_table: This is the remote node table from which the remote node
* release is to take place. * release is to take place.
* * @remote_node_index: This is the remote node index that is being released.
* This method will free a single remote node index back to the remote node * This method will free a single remote node index back to the remote node
* table. This routine will update the remote node groups * table. This routine will update the remote node groups
*/ */
...@@ -552,6 +551,7 @@ static void sci_remote_node_table_release_single_remote_node( ...@@ -552,6 +551,7 @@ static void sci_remote_node_table_release_single_remote_node(
* sci_remote_node_table_release_triple_remote_node() * sci_remote_node_table_release_triple_remote_node()
* @remote_node_table: This is the remote node table to which the remote node * @remote_node_table: This is the remote node table to which the remote node
* index is to be freed. * index is to be freed.
* @remote_node_index: This is the remote node index that is being released.
* *
* This method will release a group of three consecutive remote nodes back to * This method will release a group of three consecutive remote nodes back to
* the free remote nodes. * the free remote nodes.
...@@ -577,6 +577,7 @@ static void sci_remote_node_table_release_triple_remote_node( ...@@ -577,6 +577,7 @@ static void sci_remote_node_table_release_triple_remote_node(
* to be freed. * to be freed.
* @remote_node_count: This is the count of consecutive remote nodes that are * @remote_node_count: This is the count of consecutive remote nodes that are
* to be freed. * to be freed.
* @remote_node_index: This is the remote node index that is being released.
* *
* This method will release the remote node index back into the remote node * This method will release the remote node index back into the remote node
* table free pool. * table free pool.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment