Commit 197df18f authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Lee Jones

mfd: max77620: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 5f9e832c
...@@ -416,9 +416,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip) ...@@ -416,9 +416,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
for_each_child_of_node(fps_np, fps_child) { for_each_child_of_node(fps_np, fps_child) {
ret = max77620_config_fps(chip, fps_child); ret = max77620_config_fps(chip, fps_child);
if (ret < 0) if (ret < 0) {
of_node_put(fps_child);
return ret; return ret;
} }
}
config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0; config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2, ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment