Commit 1a54c0cf authored by Dan Carpenter's avatar Dan Carpenter Committed by Anna Schumaker

sunrpc: kstrtoul() can also return -ERANGE

Smatch complains that "num" can be uninitialized when kstrtoul() returns
-ERANGE.  It's true enough, but basically harmless in this case.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 379ebf07
...@@ -50,7 +50,7 @@ static int param_set_hashtbl_sz(const char *val, const struct kernel_param *kp) ...@@ -50,7 +50,7 @@ static int param_set_hashtbl_sz(const char *val, const struct kernel_param *kp)
if (!val) if (!val)
goto out_inval; goto out_inval;
ret = kstrtoul(val, 0, &num); ret = kstrtoul(val, 0, &num);
if (ret == -EINVAL) if (ret)
goto out_inval; goto out_inval;
nbits = fls(num - 1); nbits = fls(num - 1);
if (nbits > MAX_HASHTABLE_BITS || nbits < 2) if (nbits > MAX_HASHTABLE_BITS || nbits < 2)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment