Commit 1aa844b9 authored by Kaixu Xia's avatar Kaixu Xia Committed by Jakub Kicinski

net: pch_gbe: remove unneeded variable retval in __pch_gbe_suspend

Fix the following coccicheck warning:

./drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2415:5-11: Unneeded variable: "retval". Return "0" on line 2435
Reported-by: default avatarTosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: default avatarKaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1604837580-12419-1-git-send-email-kaixuxia@tencent.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3ec94da9
...@@ -2412,7 +2412,6 @@ static int __pch_gbe_suspend(struct pci_dev *pdev) ...@@ -2412,7 +2412,6 @@ static int __pch_gbe_suspend(struct pci_dev *pdev)
struct pch_gbe_adapter *adapter = netdev_priv(netdev); struct pch_gbe_adapter *adapter = netdev_priv(netdev);
struct pch_gbe_hw *hw = &adapter->hw; struct pch_gbe_hw *hw = &adapter->hw;
u32 wufc = adapter->wake_up_evt; u32 wufc = adapter->wake_up_evt;
int retval = 0;
netif_device_detach(netdev); netif_device_detach(netdev);
if (netif_running(netdev)) if (netif_running(netdev))
...@@ -2432,7 +2431,7 @@ static int __pch_gbe_suspend(struct pci_dev *pdev) ...@@ -2432,7 +2431,7 @@ static int __pch_gbe_suspend(struct pci_dev *pdev)
pch_gbe_mac_set_wol_event(hw, wufc); pch_gbe_mac_set_wol_event(hw, wufc);
pci_disable_device(pdev); pci_disable_device(pdev);
} }
return retval; return 0;
} }
#ifdef CONFIG_PM #ifdef CONFIG_PM
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment