Commit 1c8542c7 authored by Li Zefan's avatar Li Zefan Committed by Al Viro

sysfs: use memdup_user()

Remove open-coded memdup_user().
Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent dae7b665
...@@ -157,14 +157,9 @@ static ssize_t write(struct file *file, const char __user *userbuf, ...@@ -157,14 +157,9 @@ static ssize_t write(struct file *file, const char __user *userbuf,
count = size - offs; count = size - offs;
} }
temp = kmalloc(count, GFP_KERNEL); temp = memdup_user(userbuf, count);
if (!temp) if (IS_ERR(temp))
return -ENOMEM; return PTR_ERR(temp);
if (copy_from_user(temp, userbuf, count)) {
count = -EFAULT;
goto out_free;
}
mutex_lock(&bb->mutex); mutex_lock(&bb->mutex);
...@@ -176,8 +171,6 @@ static ssize_t write(struct file *file, const char __user *userbuf, ...@@ -176,8 +171,6 @@ static ssize_t write(struct file *file, const char __user *userbuf,
if (count > 0) if (count > 0)
*off = offs + count; *off = offs + count;
out_free:
kfree(temp);
return count; return count;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment