Commit 1deeb640 authored by David Ahern's avatar David Ahern Committed by David S. Miller

ipv6: Remove flowi6_oif compare from __ip6_route_redirect

In the review of 0b34eb00 ("ipv6: Refactor __ip6_route_redirect"),
Martin noted that the flowi6_oif compare is moved to the new helper and
should be removed from __ip6_route_redirect. Fix the oversight.

Fixes: 0b34eb00 ("ipv6: Refactor __ip6_route_redirect")
Reported-by: default avatarMartin Lau <kafai@fb.com>
Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8c5a3ca3
...@@ -2471,8 +2471,6 @@ static struct rt6_info *__ip6_route_redirect(struct net *net, ...@@ -2471,8 +2471,6 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,
continue; continue;
if (rt->fib6_flags & RTF_REJECT) if (rt->fib6_flags & RTF_REJECT)
break; break;
if (fl6->flowi6_oif != rt->fib6_nh.fib_nh_dev->ifindex)
continue;
if (ip6_redirect_nh_match(rt, &rt->fib6_nh, fl6, if (ip6_redirect_nh_match(rt, &rt->fib6_nh, fl6,
&rdfl->gateway, &ret)) &rdfl->gateway, &ret))
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment