Commit 1df931d9 authored by Jan Beulich's avatar Jan Beulich Committed by Paolo Bonzini

x86: drop bogus "cc" clobber from __try_cmpxchg_user_asm()

As noted (and fixed) a couple of times in the past, "=@cc<cond>" outputs
and clobbering of "cc" don't work well together. The compiler appears to
mean to reject such, but doesn't - in its upstream form - quite manage
to yet for "cc". Furthermore two similar macros don't clobber "cc", and
clobbering "cc" is pointless in asm()-s for x86 anyway - the compiler
always assumes status flags to be clobbered there.

Fixes: 989b5db2 ("x86/uaccess: Implement macros for CMPXCHG on user addresses")
Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Message-Id: <485c0c0b-a3a7-0b7c-5264-7d00c01de032@suse.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent cf4a8693
...@@ -439,7 +439,7 @@ do { \ ...@@ -439,7 +439,7 @@ do { \
[ptr] "+m" (*_ptr), \ [ptr] "+m" (*_ptr), \
[old] "+a" (__old) \ [old] "+a" (__old) \
: [new] ltype (__new) \ : [new] ltype (__new) \
: "memory", "cc"); \ : "memory"); \
if (unlikely(__err)) \ if (unlikely(__err)) \
goto label; \ goto label; \
if (unlikely(!success)) \ if (unlikely(!success)) \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment