Commit 1f1120a5 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

nfp: don't dereference a null nn->eth_port to print a warning

On the case where nn->eth_port is null the warning message
is printing the port by dereferencing this null pointer.
Remove the deference to avoid a crash when printing the
warning message.

Detected by CoverityScan, CID#1426198 ("Dereference after null check")

Fixes: ce22f5a2 ("nfp: separate high level and low level NSP headers")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7cb164ef
...@@ -495,8 +495,7 @@ static void nfp_net_refresh_netdevs(struct work_struct *work) ...@@ -495,8 +495,7 @@ static void nfp_net_refresh_netdevs(struct work_struct *work)
list_for_each_entry_safe(nn, next, &pf->ports, port_list) { list_for_each_entry_safe(nn, next, &pf->ports, port_list) {
if (!nn->eth_port) { if (!nn->eth_port) {
nfp_warn(pf->cpp, "Warning: port %d not present after reconfig\n", nfp_warn(pf->cpp, "Warning: port not present after reconfig\n");
nn->eth_port->eth_index);
continue; continue;
} }
if (!nn->eth_port->override_changed) if (!nn->eth_port->override_changed)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment