Commit 20b271df authored by Ira Weiny's avatar Ira Weiny Committed by Linus Torvalds

arch/kmap: define kmap_atomic_prot() for all arch's

To support kmap_atomic_prot(), all architectures need to support
protections passed to their kmap_atomic_high() function.  Pass protections
into kmap_atomic_high() and change the name to kmap_atomic_high_prot() to
match.

Then define kmap_atomic_prot() as a core function which calls
kmap_atomic_high_prot() when needed.

Finally, redefine kmap_atomic() as a wrapper of kmap_atomic_prot() with
the default kmap_prot exported by the architectures.
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Christian König <christian.koenig@amd.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Helge Deller <deller@gmx.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20200507150004.1423069-11-ira.weiny@intel.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d8c25836
...@@ -49,7 +49,7 @@ ...@@ -49,7 +49,7 @@
extern pte_t * pkmap_page_table; extern pte_t * pkmap_page_table;
static pte_t * fixmap_page_table; static pte_t * fixmap_page_table;
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
int idx, cpu_idx; int idx, cpu_idx;
unsigned long vaddr; unsigned long vaddr;
...@@ -59,11 +59,11 @@ void *kmap_atomic_high(struct page *page) ...@@ -59,11 +59,11 @@ void *kmap_atomic_high(struct page *page)
vaddr = FIXMAP_ADDR(idx); vaddr = FIXMAP_ADDR(idx);
set_pte_at(&init_mm, vaddr, fixmap_page_table + idx, set_pte_at(&init_mm, vaddr, fixmap_page_table + idx,
mk_pte(page, kmap_prot)); mk_pte(page, prot));
return (void *)vaddr; return (void *)vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kv) void kunmap_atomic_high(void *kv)
{ {
......
...@@ -31,7 +31,7 @@ static inline pte_t get_fixmap_pte(unsigned long vaddr) ...@@ -31,7 +31,7 @@ static inline pte_t get_fixmap_pte(unsigned long vaddr)
return *ptep; return *ptep;
} }
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
unsigned int idx; unsigned int idx;
unsigned long vaddr; unsigned long vaddr;
...@@ -67,11 +67,11 @@ void *kmap_atomic_high(struct page *page) ...@@ -67,11 +67,11 @@ void *kmap_atomic_high(struct page *page)
* in place, so the contained TLB flush ensures the TLB is updated * in place, so the contained TLB flush ensures the TLB is updated
* with the new mapping. * with the new mapping.
*/ */
set_fixmap_pte(idx, mk_pte(page, kmap_prot)); set_fixmap_pte(idx, mk_pte(page, prot));
return (void *)vaddr; return (void *)vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kvaddr) void kunmap_atomic_high(void *kvaddr)
{ {
......
...@@ -21,7 +21,7 @@ EXPORT_SYMBOL(kmap_flush_tlb); ...@@ -21,7 +21,7 @@ EXPORT_SYMBOL(kmap_flush_tlb);
EXPORT_SYMBOL(kmap); EXPORT_SYMBOL(kmap);
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
unsigned long vaddr; unsigned long vaddr;
int idx, type; int idx, type;
...@@ -32,12 +32,12 @@ void *kmap_atomic_high(struct page *page) ...@@ -32,12 +32,12 @@ void *kmap_atomic_high(struct page *page)
#ifdef CONFIG_DEBUG_HIGHMEM #ifdef CONFIG_DEBUG_HIGHMEM
BUG_ON(!pte_none(*(kmap_pte - idx))); BUG_ON(!pte_none(*(kmap_pte - idx)));
#endif #endif
set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); set_pte(kmap_pte-idx, mk_pte(page, prot));
flush_tlb_one((unsigned long)vaddr); flush_tlb_one((unsigned long)vaddr);
return (void *)vaddr; return (void *)vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kvaddr) void kunmap_atomic_high(void *kvaddr)
{ {
......
...@@ -51,22 +51,6 @@ extern pte_t *pkmap_page_table; ...@@ -51,22 +51,6 @@ extern pte_t *pkmap_page_table;
#define PKMAP_NR(virt) ((virt - PKMAP_BASE) >> PAGE_SHIFT) #define PKMAP_NR(virt) ((virt - PKMAP_BASE) >> PAGE_SHIFT)
#define PKMAP_ADDR(nr) (PKMAP_BASE + ((nr) << PAGE_SHIFT)) #define PKMAP_ADDR(nr) (PKMAP_BASE + ((nr) << PAGE_SHIFT))
extern void *kmap_atomic_high_prot(struct page *page, pgprot_t prot);
static inline void *kmap_atomic_prot(struct page *page, pgprot_t prot)
{
preempt_disable();
pagefault_disable();
if (!PageHighMem(page))
return page_address(page);
return kmap_atomic_high_prot(page, prot);
}
static inline void *kmap_atomic_high(struct page *page)
{
return kmap_atomic_high_prot(page, kmap_prot);
}
#define flush_cache_kmaps() { flush_icache(); flush_dcache(); } #define flush_cache_kmaps() { flush_icache(); flush_dcache(); }
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */
......
...@@ -18,7 +18,7 @@ void kmap_flush_tlb(unsigned long addr) ...@@ -18,7 +18,7 @@ void kmap_flush_tlb(unsigned long addr)
} }
EXPORT_SYMBOL(kmap_flush_tlb); EXPORT_SYMBOL(kmap_flush_tlb);
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
unsigned long vaddr; unsigned long vaddr;
int idx, type; int idx, type;
...@@ -29,12 +29,12 @@ void *kmap_atomic_high(struct page *page) ...@@ -29,12 +29,12 @@ void *kmap_atomic_high(struct page *page)
#ifdef CONFIG_DEBUG_HIGHMEM #ifdef CONFIG_DEBUG_HIGHMEM
BUG_ON(!pte_none(*(kmap_pte - idx))); BUG_ON(!pte_none(*(kmap_pte - idx)));
#endif #endif
set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); set_pte(kmap_pte-idx, mk_pte(page, prot));
local_flush_tlb_one((unsigned long)vaddr); local_flush_tlb_one((unsigned long)vaddr);
return (void*) vaddr; return (void*) vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kvaddr) void kunmap_atomic_high(void *kvaddr)
{ {
......
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
#include <asm/fixmap.h> #include <asm/fixmap.h>
#include <asm/tlbflush.h> #include <asm/tlbflush.h>
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
unsigned int idx; unsigned int idx;
unsigned long vaddr, pte; unsigned long vaddr, pte;
...@@ -21,7 +21,7 @@ void *kmap_atomic_high(struct page *page) ...@@ -21,7 +21,7 @@ void *kmap_atomic_high(struct page *page)
idx = type + KM_TYPE_NR * smp_processor_id(); idx = type + KM_TYPE_NR * smp_processor_id();
vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx);
pte = (page_to_pfn(page) << PAGE_SHIFT) | (kmap_prot); pte = (page_to_pfn(page) << PAGE_SHIFT) | prot;
ptep = pte_offset_kernel(pmd_off_k(vaddr), vaddr); ptep = pte_offset_kernel(pmd_off_k(vaddr), vaddr);
set_pte(ptep, pte); set_pte(ptep, pte);
...@@ -31,7 +31,7 @@ void *kmap_atomic_high(struct page *page) ...@@ -31,7 +31,7 @@ void *kmap_atomic_high(struct page *page)
__nds32__isb(); __nds32__isb();
return (void *)vaddr; return (void *)vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kvaddr) void kunmap_atomic_high(void *kvaddr)
{ {
......
...@@ -59,23 +59,6 @@ extern pte_t *pkmap_page_table; ...@@ -59,23 +59,6 @@ extern pte_t *pkmap_page_table;
#define PKMAP_NR(virt) ((virt-PKMAP_BASE) >> PAGE_SHIFT) #define PKMAP_NR(virt) ((virt-PKMAP_BASE) >> PAGE_SHIFT)
#define PKMAP_ADDR(nr) (PKMAP_BASE + ((nr) << PAGE_SHIFT)) #define PKMAP_ADDR(nr) (PKMAP_BASE + ((nr) << PAGE_SHIFT))
extern void *kmap_atomic_high_prot(struct page *page, pgprot_t prot);
static inline void *kmap_atomic_prot(struct page *page, pgprot_t prot)
{
preempt_disable();
pagefault_disable();
if (!PageHighMem(page))
return page_address(page);
return kmap_atomic_high_prot(page, prot);
}
static inline void *kmap_atomic_high(struct page *page)
{
return kmap_atomic_high_prot(page, kmap_prot);
}
#define flush_cache_kmaps() flush_cache_all() #define flush_cache_kmaps() flush_cache_all()
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */
......
...@@ -54,7 +54,7 @@ void __init kmap_init(void) ...@@ -54,7 +54,7 @@ void __init kmap_init(void)
kmap_prot = __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); kmap_prot = __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE);
} }
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
unsigned long vaddr; unsigned long vaddr;
long idx, type; long idx, type;
...@@ -73,7 +73,7 @@ void *kmap_atomic_high(struct page *page) ...@@ -73,7 +73,7 @@ void *kmap_atomic_high(struct page *page)
#ifdef CONFIG_DEBUG_HIGHMEM #ifdef CONFIG_DEBUG_HIGHMEM
BUG_ON(!pte_none(*(kmap_pte-idx))); BUG_ON(!pte_none(*(kmap_pte-idx)));
#endif #endif
set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); set_pte(kmap_pte-idx, mk_pte(page, prot));
/* XXX Fix - Anton */ /* XXX Fix - Anton */
#if 0 #if 0
__flush_tlb_one(vaddr); __flush_tlb_one(vaddr);
...@@ -83,7 +83,7 @@ void *kmap_atomic_high(struct page *page) ...@@ -83,7 +83,7 @@ void *kmap_atomic_high(struct page *page)
return (void*) vaddr; return (void*) vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kvaddr) void kunmap_atomic_high(void *kvaddr)
{ {
......
...@@ -58,20 +58,6 @@ extern unsigned long highstart_pfn, highend_pfn; ...@@ -58,20 +58,6 @@ extern unsigned long highstart_pfn, highend_pfn;
#define PKMAP_NR(virt) ((virt-PKMAP_BASE) >> PAGE_SHIFT) #define PKMAP_NR(virt) ((virt-PKMAP_BASE) >> PAGE_SHIFT)
#define PKMAP_ADDR(nr) (PKMAP_BASE + ((nr) << PAGE_SHIFT)) #define PKMAP_ADDR(nr) (PKMAP_BASE + ((nr) << PAGE_SHIFT))
extern void *kmap_atomic_high_prot(struct page *page, pgprot_t prot);
static inline void *kmap_atomic_prot(struct page *page, pgprot_t prot)
{
preempt_disable();
pagefault_disable();
if (!PageHighMem(page))
return page_address(page);
return kmap_atomic_high_prot(page, prot);
}
static inline void *kmap_atomic_high(struct page *page)
{
return kmap_atomic_high_prot(page, kmap_prot);
}
void *kmap_atomic_pfn(unsigned long pfn); void *kmap_atomic_pfn(unsigned long pfn);
void *kmap_atomic_prot_pfn(unsigned long pfn, pgprot_t prot); void *kmap_atomic_prot_pfn(unsigned long pfn, pgprot_t prot);
......
...@@ -37,7 +37,7 @@ static inline enum fixed_addresses kmap_idx(int type, unsigned long color) ...@@ -37,7 +37,7 @@ static inline enum fixed_addresses kmap_idx(int type, unsigned long color)
color; color;
} }
void *kmap_atomic_high(struct page *page) void *kmap_atomic_high_prot(struct page *page, pgprot_t prot)
{ {
enum fixed_addresses idx; enum fixed_addresses idx;
unsigned long vaddr; unsigned long vaddr;
...@@ -48,11 +48,11 @@ void *kmap_atomic_high(struct page *page) ...@@ -48,11 +48,11 @@ void *kmap_atomic_high(struct page *page)
#ifdef CONFIG_DEBUG_HIGHMEM #ifdef CONFIG_DEBUG_HIGHMEM
BUG_ON(!pte_none(*(kmap_pte + idx))); BUG_ON(!pte_none(*(kmap_pte + idx)));
#endif #endif
set_pte(kmap_pte + idx, mk_pte(page, kmap_prot)); set_pte(kmap_pte + idx, mk_pte(page, prot));
return (void *)vaddr; return (void *)vaddr;
} }
EXPORT_SYMBOL(kmap_atomic_high); EXPORT_SYMBOL(kmap_atomic_high_prot);
void kunmap_atomic_high(void *kvaddr) void kunmap_atomic_high(void *kvaddr)
{ {
......
...@@ -32,7 +32,7 @@ static inline void invalidate_kernel_vmap_range(void *vaddr, int size) ...@@ -32,7 +32,7 @@ static inline void invalidate_kernel_vmap_range(void *vaddr, int size)
#include <asm/kmap_types.h> #include <asm/kmap_types.h>
#ifdef CONFIG_HIGHMEM #ifdef CONFIG_HIGHMEM
extern void *kmap_atomic_high(struct page *page); extern void *kmap_atomic_high_prot(struct page *page, pgprot_t prot);
extern void kunmap_atomic_high(void *kvaddr); extern void kunmap_atomic_high(void *kvaddr);
#include <asm/highmem.h> #include <asm/highmem.h>
...@@ -77,14 +77,15 @@ static inline void kunmap(struct page *page) ...@@ -77,14 +77,15 @@ static inline void kunmap(struct page *page)
* be used in IRQ contexts, so in some (very limited) cases we need * be used in IRQ contexts, so in some (very limited) cases we need
* it. * it.
*/ */
static inline void *kmap_atomic(struct page *page) static inline void *kmap_atomic_prot(struct page *page, pgprot_t prot)
{ {
preempt_disable(); preempt_disable();
pagefault_disable(); pagefault_disable();
if (!PageHighMem(page)) if (!PageHighMem(page))
return page_address(page); return page_address(page);
return kmap_atomic_high(page); return kmap_atomic_high_prot(page, prot);
} }
#define kmap_atomic(page) kmap_atomic_prot(page, kmap_prot)
/* declarations for linux/mm/highmem.c */ /* declarations for linux/mm/highmem.c */
unsigned int nr_free_highpages(void); unsigned int nr_free_highpages(void);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment