Commit 20c7e296 authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull stacktrace fix from Thomas Gleixner:
 "A small fix for a stacktrace regression.

  Saving a stacktrace for a foreign task skipped an extra entry which
  makes e.g. the output of /proc/$PID/stack incomplete"

* 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  stacktrace: Don't skip first entry on noncurrent tasks
parents 79a64063 b0c51f15
...@@ -141,7 +141,8 @@ unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store, ...@@ -141,7 +141,8 @@ unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store,
struct stacktrace_cookie c = { struct stacktrace_cookie c = {
.store = store, .store = store,
.size = size, .size = size,
.skip = skipnr + 1, /* skip this function if they are tracing us */
.skip = skipnr + !!(current == tsk),
}; };
if (!try_get_task_stack(tsk)) if (!try_get_task_stack(tsk))
...@@ -298,7 +299,8 @@ unsigned int stack_trace_save_tsk(struct task_struct *task, ...@@ -298,7 +299,8 @@ unsigned int stack_trace_save_tsk(struct task_struct *task,
struct stack_trace trace = { struct stack_trace trace = {
.entries = store, .entries = store,
.max_entries = size, .max_entries = size,
.skip = skipnr + 1, /* skip this function if they are tracing us */
.skip = skipnr + !!(current == task),
}; };
save_stack_trace_tsk(task, &trace); save_stack_trace_tsk(task, &trace);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment