Commit 233363ab authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown

spi/panel: dt-bindings: drop CPHA and CPOL from common properties

The spi-cpha and spi-cpol properties are device specific and should be
accepted only if device really needs them.  Drop them from common
spi-peripheral-props.yaml schema, mention in few panel drivers which use
them and include instead in the SPI controller bindings.  The controller
bindings will provide CPHA/CPOL type validation and one place for
description.  Each device schema must list the properties if they are
applicable.
Suggested-by: default avatarJonathan Cameron <jic23@kernel.org>
Suggested-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220722191539.90641-2-krzysztof.kozlowski@linaro.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 89fcdd53
...@@ -21,6 +21,9 @@ properties: ...@@ -21,6 +21,9 @@ properties:
enable-gpios: true enable-gpios: true
port: true port: true
spi-cpha: true
spi-cpol: true
required: required:
- compatible - compatible
- enable-gpios - enable-gpios
......
...@@ -42,6 +42,9 @@ properties: ...@@ -42,6 +42,9 @@ properties:
panel-height-mm: panel-height-mm:
description: physical panel height [mm] description: physical panel height [mm]
spi-cpha: true
spi-cpol: true
required: required:
- compatible - compatible
- reg - reg
......
...@@ -23,6 +23,9 @@ properties: ...@@ -23,6 +23,9 @@ properties:
backlight: true backlight: true
port: true port: true
spi-cpha: true
spi-cpol: true
required: required:
- compatible - compatible
- reg - reg
......
...@@ -28,6 +28,9 @@ properties: ...@@ -28,6 +28,9 @@ properties:
backlight: true backlight: true
port: true port: true
spi-cpha: true
spi-cpol: true
required: required:
- compatible - compatible
- port - port
......
...@@ -95,6 +95,17 @@ patternProperties: ...@@ -95,6 +95,17 @@ patternProperties:
type: object type: object
$ref: spi-peripheral-props.yaml $ref: spi-peripheral-props.yaml
properties:
spi-cpha:
$ref: /schemas/types.yaml#/definitions/flag
description:
The device requires shifted clock phase (CPHA) mode.
spi-cpol:
$ref: /schemas/types.yaml#/definitions/flag
description:
The device requires inverse clock polarity (CPOL) mode.
required: required:
- compatible - compatible
- reg - reg
......
...@@ -34,16 +34,6 @@ properties: ...@@ -34,16 +34,6 @@ properties:
description: description:
The device requires 3-wire mode. The device requires 3-wire mode.
spi-cpha:
$ref: /schemas/types.yaml#/definitions/flag
description:
The device requires shifted clock phase (CPHA) mode.
spi-cpol:
$ref: /schemas/types.yaml#/definitions/flag
description:
The device requires inverse clock polarity (CPOL) mode.
spi-cs-high: spi-cs-high:
$ref: /schemas/types.yaml#/definitions/flag $ref: /schemas/types.yaml#/definitions/flag
description: description:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment