Commit 2413fc7a authored by Konstantin Khlebnikov's avatar Konstantin Khlebnikov Committed by Kamal Mostafa

ovl: copy new uid/gid into overlayfs runtime inode

commit b81de061 upstream.

Overlayfs must update uid/gid after chown, otherwise functions
like inode_owner_or_capable() will check user against stale uid.
Catched by xfstests generic/087, it chowns file and calls utimes.
Signed-off-by: default avatarKonstantin Khlebnikov <koct9i@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <miklos@szeredi.hu>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent f9da9f69
...@@ -55,6 +55,8 @@ int ovl_setattr(struct dentry *dentry, struct iattr *attr) ...@@ -55,6 +55,8 @@ int ovl_setattr(struct dentry *dentry, struct iattr *attr)
mutex_lock(&upperdentry->d_inode->i_mutex); mutex_lock(&upperdentry->d_inode->i_mutex);
err = notify_change(upperdentry, attr, NULL); err = notify_change(upperdentry, attr, NULL);
if (!err)
ovl_copyattr(upperdentry->d_inode, dentry->d_inode);
mutex_unlock(&upperdentry->d_inode->i_mutex); mutex_unlock(&upperdentry->d_inode->i_mutex);
} }
ovl_drop_write(dentry); ovl_drop_write(dentry);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment