Commit 255e51da authored by Colin Ian King's avatar Colin Ian King Committed by Thomas Bogendoerfer

MIPS: generic/yamon-dt: fix uninitialized variable error

In the case where fw_getenv returns an error when fetching values
for ememsizea and memsize then variable phys_memsize is not assigned
a variable and will be uninitialized on a zero check of phys_memsize.
Fix this by initializing phys_memsize to zero.

Cleans up cppcheck error:
arch/mips/generic/yamon-dt.c:100:7: error: Uninitialized variable: phys_memsize [uninitvar]

Fixes: f41d2430 ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent b3ff2881
...@@ -75,7 +75,7 @@ static unsigned int __init gen_fdt_mem_array( ...@@ -75,7 +75,7 @@ static unsigned int __init gen_fdt_mem_array(
__init int yamon_dt_append_memory(void *fdt, __init int yamon_dt_append_memory(void *fdt,
const struct yamon_mem_region *regions) const struct yamon_mem_region *regions)
{ {
unsigned long phys_memsize, memsize; unsigned long phys_memsize = 0, memsize;
__be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES]; __be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES];
unsigned int mem_entries; unsigned int mem_entries;
int i, err, mem_off; int i, err, mem_off;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment