Commit 25aa4efe authored by andrew hendry's avatar andrew hendry Committed by David S. Miller

X.25 remove bkl in listen

Listen updates socket values and needs lock_sock.
Signed-off-by: default avatarAndrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 55b1804c
...@@ -507,14 +507,14 @@ static int x25_listen(struct socket *sock, int backlog) ...@@ -507,14 +507,14 @@ static int x25_listen(struct socket *sock, int backlog)
struct sock *sk = sock->sk; struct sock *sk = sock->sk;
int rc = -EOPNOTSUPP; int rc = -EOPNOTSUPP;
lock_kernel(); lock_sock(sk);
if (sk->sk_state != TCP_LISTEN) { if (sk->sk_state != TCP_LISTEN) {
memset(&x25_sk(sk)->dest_addr, 0, X25_ADDR_LEN); memset(&x25_sk(sk)->dest_addr, 0, X25_ADDR_LEN);
sk->sk_max_ack_backlog = backlog; sk->sk_max_ack_backlog = backlog;
sk->sk_state = TCP_LISTEN; sk->sk_state = TCP_LISTEN;
rc = 0; rc = 0;
} }
unlock_kernel(); release_sock(sk);
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment