Commit 27b2a22c authored by Sachin Kamat's avatar Sachin Kamat Committed by Takashi Iwai

ALSA: usb/6fire: Fix potential NULL pointer dereference in comm.c

'rt' was dereferenced before the NULL check.
Moved the code after the check.
Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6cf95152
...@@ -129,12 +129,13 @@ int __devinit usb6fire_comm_init(struct sfire_chip *chip) ...@@ -129,12 +129,13 @@ int __devinit usb6fire_comm_init(struct sfire_chip *chip)
{ {
struct comm_runtime *rt = kzalloc(sizeof(struct comm_runtime), struct comm_runtime *rt = kzalloc(sizeof(struct comm_runtime),
GFP_KERNEL); GFP_KERNEL);
struct urb *urb = &rt->receiver; struct urb *urb;
int ret; int ret;
if (!rt) if (!rt)
return -ENOMEM; return -ENOMEM;
urb = &rt->receiver;
rt->serial = 1; rt->serial = 1;
rt->chip = chip; rt->chip = chip;
usb_init_urb(urb); usb_init_urb(urb);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment